Bug #49910 for List-Categorize:

Tue Sep 22 10:29:22 2009 lodin [...] cpan.org - Ticket created

Hello Bill, I just found your module List::Categorize and it seems convenient. I noted however the line my $category = &$coderef; in the source. It is perhaps not technically a bug, but it could be quite confusing if one tries to use @_ in the block. A contrived example: categorize { pop; $_ } 1 .. 4 # (1 => [ 1 ], 2 => [ 2 ]) (See "What's the difference between calling a function as &foo and foo()?" in perlfaq7 for more.) This is easily fixed by just changing "&$coderef" to "&$coderef()" or "$coderef->()", or a comment in the documentation if this indeed is the intended behaviour. Regards, Johan Lodin

Tue Sep 22 17:53:43 2009 bill [...] billodom.com - Correspondence added

On Tue Sep 22 10:29:22 2009, LODIN wrote: Show quoted text

> > I just found your module List::Categorize and it seems convenient. I > noted however the line > > my $category = &$coderef; > > in the source. It is perhaps not technically a bug, but it could be > quite confusing if one tries to use @_ in the block. A contrived example: > > categorize { pop; $_ } 1 .. 4 # (1 => [ 1 ], 2 => [ 2 ]) > > (See "What's the difference between calling a function as &foo and > foo()?" in perlfaq7 for more.) > > This is easily fixed by just changing "&$coderef" to "&$coderef()" or > "$coderef->()", or a comment in the documentation if this indeed is the > intended behaviour. >

Argh. Good catch. That crept in when I was experimenting with passing arguments to the categorizer, and I didn't change it back. I'll take care of it in the next update (which should be pretty soon). Thanks, Bill

Tue Sep 22 17:53:44 2009 The RT System itself - Status changed from 'new' to 'open'

Tue Sep 22 17:54:02 2009 bill [...] billodom.com - Taken

Tue Sep 22 20:33:07 2009 bill [...] billodom.com - Correspondence added

Okay, version 0.03 has been uploaded to the CPAN, with the fix in place!

Tue Sep 22 20:33:08 2009 bill [...] billodom.com - Status changed from 'open' to 'resolved'