Skip Menu |

This queue is for tickets about the Shipwright CPAN distribution.

Report information
The Basics
Id: 49832
Status: resolved
Priority: 0/
Queue: Shipwright
People
Owner: Nobody in particular
Requestors: rmb32 [...] cornell.edu
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 2.4.1
Fixed in: (no value)

History Show all quoted text
  Sat Sep 19 03:44:20 2009 rmb32 [...] cornell.edu - Ticket created
Subject: Module::Build patching has strange interactions with some distros
Here's a shell script demonstrating the problem: #!/bin/sh SHIPWRIGHT_REPOSITORY=fs:/tmp/mb_patch_problem_demo; cd; rm -rf /tmp/mb_patch_problem_demo; shipwright create; shipwright import cpan:CGI::Simple; cd /tmp/foo; rm -rf dists; rm -rf /tmp/vessel_*; bin/shipwright-builder --skip-test --skip-man-pages --verbose The build of CGI::Simple fails if Shipwright::Util::PatchModuleBuild is active.
  Sat Sep 19 03:50:39 2009 rmb32 [...] cornell.edu - Correspondence added
In the example above, it looks like it has something to do with CGI::Simple's MyBuilder M::B subclass object, and its use of 'use base'. Either of the following two changes ameliorate the problem. I'd suggest the first one as the fix for this, unless just use'ing Module::Build itself in the import has some kind of big downside that I don't get. Index: Shipwright/Util/PatchModuleBuild.pm =================================================================== --- Shipwright/Util/PatchModuleBuild.pm (revision 1107) +++ Shipwright/Util/PatchModuleBuild.pm (working copy) @@ -4,7 +4,7 @@ sub import { - use Module::Build::Base; + use Module::Build; no warnings qw'redefine'; sub Module::Build::Base::ACTION_manpages {} ## no critic sub Module::Build::Base::ACTION_docs {} ## no critic Index: sources/cpan-CGI-Simple/vendor/inc/MyBuilder.pm =================================================================== --- sources/cpan-CGI-Simple/vendor/inc/MyBuilder.pm (revision 1107) +++ sources/cpan-CGI-Simple/vendor/inc/MyBuilder.pm (working copy) @@ -1,5 +1,6 @@ package MyBuilder; +use Module::Build; use base qw( Module::Build ); sub create_build_script {
  Sat Sep 19 03:50:42 2009 rmb32 [...] cornell.edu - Status changed from 'new' to 'open'
  Sun Sep 20 21:35:09 2009 sunnavy [...] gmail.com - Correspondence added
next version(2.4.2) will contain this patch. thanks very much! best wishes sunnavy
  Sun Sep 20 21:35:13 2009 sunnavy [...] gmail.com - Status changed from 'open' to 'resolved'