Skip Menu |

This queue is for tickets about the List-MoreUtils CPAN distribution.

Report information
The Basics
Id: 49800
Status: resolved
Priority: 0/
Queue: List-MoreUtils
People
Owner: Nobody in particular
Requestors: dekimsey [...] gmail.com
THEPLER [...] cpan.org
user42 [...] zip.com.au
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.407

History Show all quoted text
  Tue Jul 08 12:02:03 2008 dekimsey [...] gmail.com - Ticket #37533: Ticket created
Subject: bug: uniq doesn't like undef values.
When using uniq on an array with undef values, warnings complains loudly. "Use of uninitialized value in subroutine entry at line 7". Although the correct uniq results will be returned, warnings doens't like it much. === use warnings; use List::MoreUtils qw(uniq); use Data::Dumper; my @foo = ('a','b', undef, 'b'); @foo = uniq @foo; # line 7. print Dumper \@foo; === This is perl 5.8.8 on linux.
  Wed Feb 11 15:14:07 2009 THEPLER [...] cpan.org - Ticket #43214: Ticket created
  Wed Feb 11 15:16:18 2009 THEPLER [...] cpan.org - Ticket #43214: Subject changed from (no value) to 'uniq warns on undef values'
  Wed Feb 11 15:24:07 2009 THEPLER [...] cpan.org - Ticket #43214: Correspondence added
Subject: XS version of uniq warns on undef values
This warns: $ perl -MList::MoreUtils=uniq -e 'use warnings; my @x = (undef, undef); @x = uniq(@x);' Use of uninitialized value in subroutine entry at -e line 1. Use of uninitialized value in subroutine entry at -e line 1. Use of uninitialized value in subroutine entry at -e line 1. But this does not: $ LIST_MOREUTILS_PP=1 perl -MList::MoreUtils=uniq -e 'use warnings; my @x = (undef, undef); @x = uniq(@x);' This is on perl 5.8.8. Seems like they should either both warn, or both not. I'd like them to not warn.
  Wed Feb 11 15:24:08 2009 THEPLER [...] cpan.org - Ticket #43214: Status changed from 'new' to 'open'
  Sun Jul 12 17:47:01 2009 VPARSEVAL [...] cpan.org - Ticket #37533: Correspondence added
This is resolved in 0.23 which I just uploaded to the CPAN.
  Sun Jul 12 17:47:02 2009 The RT System itself - Ticket #37533: Status changed from 'new' to 'open'
  Sun Jul 12 17:47:03 2009 VPARSEVAL [...] cpan.org - Ticket #37533: Status changed from 'open' to 'resolved'
  Sun Jul 12 17:47:57 2009 VPARSEVAL [...] cpan.org - Ticket #43214: Correspondence added
This is resolved in 0.23 which I just uploaded to the CPAN.
  Sun Jul 12 17:47:58 2009 VPARSEVAL [...] cpan.org - Ticket #43214: Status changed from 'open' to 'resolved'
  Thu Sep 17 19:25:40 2009 user42 [...] zip.com.au - Ticket created
Subject: docs of how uniq() compares
Date: Fri, 18 Sep 2009 09:25:03 +1000
To: bug-List-MoreUtils [...] rt.cpan.org
From: Kevin Ryde <user42 [...] zip.com.au>
It'd be good if the docs of uniq() said how it compared for uniqueness. The example shows only numbers, but I see the code does it by string, with a slightly doubtful allowance for undef.
  Mon Nov 29 13:19:15 2010 ether [...] cpan.org - Ticket #37533: Correspondence added
On Sun Jul 12 14:47:01 2009, VPARSEVAL wrote: Show quoted text
> This is resolved in 0.23 which I just uploaded to the CPAN.
Note that the 0.23 code line is no longer in the latest release, 0.26. Consequently this and a number of other tickets in this queue are no longer resolved.
  Mon Nov 29 13:19:16 2010 The RT System itself - Ticket #37533: Status changed from 'resolved' to 'open'
  Mon Nov 29 13:19:40 2010 ether [...] cpan.org - Ticket #43214: Correspondence added
On Sun Jul 12 14:47:57 2009, VPARSEVAL wrote: Show quoted text
> This is resolved in 0.23 which I just uploaded to the CPAN.
Note that the 0.23 code line is no longer in the latest release, 0.26. Consequently this and a number of other tickets in this queue are no longer resolved.
  Mon Nov 29 13:19:40 2010 The RT System itself - Ticket #43214: Status changed from 'resolved' to 'open'
  Fri Mar 06 09:44:19 2015 REHSACK [...] cpan.org - Correspondence added
RT-Send-CC: dagolden [...] cpan.org
Patched in d33f81de - but the behavior is weird anyway. However, it's in the wild and I tend to keep the existing behavior until lot's of CPAN admins sign with their blood that's ok to modify the behavior. If reasonable I would add a $u{defined $_ ? $_ : ""}++ - which will slow down the routine but stops complaining.
  Fri Mar 06 09:44:19 2015 The RT System itself - Status changed from 'new' to 'open'
  Fri Mar 06 09:50:57 2015 REHSACK [...] cpan.org - Ticket #43214: Correspondence added
That's finally the same issue
  Fri Mar 06 09:50:58 2015 REHSACK [...] cpan.org - Ticket #43214: Merged into ticket #49800
  Fri Mar 06 09:50:58 2015 REHSACK [...] cpan.org - Merged into ticket #49800
  Fri Mar 06 09:51:15 2015 REHSACK [...] cpan.org - Ticket #37533: Merged into ticket #49800
  Fri Mar 06 09:51:15 2015 REHSACK [...] cpan.org - Merged into ticket #49800
  Mon Mar 09 09:56:56 2015 REHSACK [...] cpan.org - Status changed from 'open' to 'patched'
  Thu Mar 19 03:37:47 2015 REHSACK [...] cpan.org - Status changed from 'patched' to 'resolved'
  Thu Mar 19 03:37:48 2015 REHSACK [...] cpan.org - Fixed in 0.407 added