Skip Menu |

This queue is for tickets about the bioperl CPAN distribution.

Report information
The Basics
Id: 49720
Status: rejected
Priority: 0/
Queue: bioperl
People
Owner: Nobody in particular
Requestors: GDM [...] cpan.org
Cc: gdm [...] savesources.com
AdminCc:
Bug Information
Severity: Normal
Broken in: 1.4
Fixed in: (no value)

History Show all quoted text
  Tue Sep 15 11:43:42 2009 GDM [...] cpan.org - Ticket created
CC: gdm [...] savesources.com
Subject: Incorrect regular expression
Hello, I've found regular expression that seems to be incorrect in file Tools/ BPLite/Iteration.pm using Google code search Line 248 is the following if ($_ =~ /(\w\w|.*|\w+.*)\s\s+(\d+)\s+([-\.e\d]+)$/) { but \w+.* cannot be cached after .* So, I propose the following variant which is equivalent of yours, but a bit simpler: if ($_ =~ /(\w\w|.*)\s\s+(\d+)\s+([-\.e\d]+)$/) { Kind regards, Dmytro Gorbunov Leader of http://savesources.com project
  Tue Sep 15 13:32:30 2009 cjfields [...] uiuc.edu - Correspondence added
On Tue Sep 15 11:43:42 2009, GDM wrote: Show quoted text
> Hello, > > I've found regular expression that seems to be incorrect in file Tools/ > BPLite/Iteration.pm using Google code search > > Line 248 is the following > if ($_ =~ /(\w\w|.*|\w+.*)\s\s+(\d+)\s+([-\.e\d]+)$/) { > > but \w+.* cannot be cached after .* > > So, I propose the following variant which is equivalent of yours, but a > bit simpler: > if ($_ =~ /(\w\w|.*)\s\s+(\d+)\s+([-\.e\d]+)$/) { > > Kind regards, > Dmytro Gorbunov > Leader of http://savesources.com project
BPLite code is deprecated (it has been removed from main trunk). I can fix this in the 1.6 release branch though.
  Tue Sep 15 13:32:31 2009 The RT System itself - Status changed from 'new' to 'open'
  Tue Sep 22 16:50:17 2009 cjfields [...] uiuc.edu - Correspondence added
On Tue Sep 15 13:32:30 2009, cjfields wrote: Show quoted text
> On Tue Sep 15 11:43:42 2009, GDM wrote:
> > Hello, > > > > I've found regular expression that seems to be incorrect in file
> Tools/
> > BPLite/Iteration.pm using Google code search > > > > Line 248 is the following > > if ($_ =~ /(\w\w|.*|\w+.*)\s\s+(\d+)\s+([-\.e\d]+)$/) { > > > > but \w+.* cannot be cached after .* > > > > So, I propose the following variant which is equivalent of yours,
> but a
> > bit simpler: > > if ($_ =~ /(\w\w|.*)\s\s+(\d+)\s+([-\.e\d]+)$/) { > > > > Kind regards, > > Dmytro Gorbunov > > Leader of http://savesources.com project
> > BPLite code is deprecated (it has been removed from main trunk). I > can fix this in the 1.6 > release branch though.
Thought this was still present in the 1.6 branch but it was deprecated prior to 1.6. Sorry, but rejecting.
  Tue Sep 22 16:50:20 2009 cjfields [...] uiuc.edu - Status changed from 'open' to 'rejected'