Bug #49701 for WWW-Myspace: [bug] WWW::Myspace broken by myspace changes

Mon Sep 14 16:38:19 2009 iwkse [...] claws-mail.org - Ticket created

Subject:	[bug] WWW::Myspace broken by myspace changes
Date:	Mon, 14 Sep 2009 22:37:43 +0200
To:	bug-WWW-Myspace [...] rt.cpan.org
From:	Salvatore De Paolis <iwkse [...] claws-mail.org>

Hi all, i'm reporting the module isn't working more, here some info that may be useful. I don't have time now (and probably the right knowledge too) to fix it so i hope one of the developers can do this :) get_friends is broken because: in _page_ok this code is executed Show quoted text

> > 6259 # Page must match the regexp > unless ( $page =~ $regexp ) { > $page_ok = 0; > $self->error("Page doesn't match verification pattern: > $regexp"); # warn "Page doesn't match verification > pattern.\n"; > }

The old pattern is: Page doesn't match verification pattern: (?i-xsm:friends.*go to my profile) Please CC me if there are messages on this bug. Best regards Salvatore

Download signature.asc
application/pgp-signature 197b

Message body not shown because it is not plain text.

Thu Sep 17 19:29:00 2009 olaf [...] wundersolutions.com - Correspondence added

On Mon Sep 14 16:38:19 2009, iwkse@claws-mail.org wrote: Show quoted text

> Hi all, > i'm reporting the module isn't working more, here some info that may > be useful. > I don't have time now (and probably the right knowledge too) to fix it > so i > hope one of the developers can do this :) > > get_friends is broken because: > > in _page_ok this code is executed

> > > > 6259 # Page must match the regexp > > unless ( $page =~ $regexp ) { > > $page_ok = 0; > > $self->error("Page doesn't match verification

> pattern:

> > $regexp"); # warn "Page doesn't match verification > > pattern.\n"; > > }

> The old pattern is: Page doesn't match verification pattern: (?i- > xsm:friends.*go > to my profile) > Please CC me if there are messages on this bug. > Best regards > Salvatore

Hi Salvatore, Thanks very much for your bug report. This module is no longer being actively maintained. I will however apply a patch, if you're able to provide one. Please see details here: http://search.cpan.org/~stevenc/WWW-Myspace-0.92/lib/WWW/Myspace.pm#HOW_TO_SUBMIT_A_PATCH Barring that, you may have more luck using the Subversion checkout of the module as it should be slightly more up to date that 0.92, which is currently in the CPAN. All the best, Olaf

Thu Sep 17 19:29:01 2009 The RT System itself - Status changed from 'new' to 'open'

Thu Sep 17 19:46:06 2009 iwkse [...] claws-mail.org - Correspondence added

Subject:	Re: [rt.cpan.org #49701] [bug] WWW::Myspace broken by myspace changes
Date:	Fri, 18 Sep 2009 01:45:24 +0200
To:	bug-WWW-Myspace [...] rt.cpan.org
From:	Salvatore De Paolis <iwkse [...] claws-mail.org>

On Thu, 17 Sep 2009 19:29:01 -0400 "Olaf Alders via RT" <bug-WWW-Myspace@rt.cpan.org> wrote: Hi Olaf, Show quoted text

> Thanks very much for your bug report. This module is no longer being > actively maintained. I will however apply a patch, if you're able to > provide one. Please see details here: > > http://search.cpan.org/~stevenc/WWW-Myspace-0.92/lib/WWW/Myspace.pm#HOW_TO_SUBMIT_A_PATCH

I didn't know this module isn't maintained more...I spoke with one developer and he said to me you're three developers working on that. Anyway i'm new with Perl and even if i understood the issue i guess i don't know how to fix it. Expecially because i don't remember (never checked) how it was the page and where it has to match the pattern "?i-> xsm:friends.*go to my profile" Show quoted text

> Barring that, you may have more luck using the Subversion checkout of > the module as it should be slightly more up to date that 0.92, which is > currently in the CPAN.

I tested it on SVN code but i get the same result. If you could give me some hints about what is matching i may try to work on a patch but i don't know if i'll be successful. Best Regards Salvatore

Download signature.asc
application/pgp-signature 197b

Message body not shown because it is not plain text.

Thu Sep 17 23:38:21 2009 olaf [...] wundersolutions.com - Correspondence added

Hi Salvatore, Show quoted text

> I didn't know this module isn't maintained more...I spoke with one > developer > and he said to me you're three developers working on that.

Don't get me wrong, there are at least 3 of us with commit access, but I haven't seen any activity here in a while. I think folks patch the module if/when they need to use it for something. Myspace changes so often that it's very hard to keep up. So, if none of us are currently working with the module, it tends to go out of sync with myspace.com Show quoted text

> Anyway i'm new with Perl and even if i understood the issue i guess i > don't > know how to fix it. Expecially because i don't remember (never > checked) how it > was the page and where it has to match the pattern "?i-> > xsm:friends.*go to my > profile"

It's ok if you're new to Perl. A lot of this stuff isn't all that complicated. We've tried to centralize most of the regular expressions. You may want to look for the following line in Myspace.pm: # let's use this to keep track of various regexes that can be used elsewhere After that line you'll see: my %regex = ( Have a look in there. You may find that that's where the offending regular expression is. Having said that, I think the regex you're looking for may be in the friend_count() method, so just look for: sub friend_count { (It's on line 1875) If you play with the regular expression in that method, that may actually fix things. Let me know how you make out. I'm sure we can get this sorted. Once the patch is applied, I'll release a new version of the module for you. All the best, Olaf