Skip Menu |

This queue is for tickets about the IPC-Run CPAN distribution.

Report information
The Basics
Id: 49693
Status: resolved
Priority: 0/
Queue: IPC-Run

People
Owner: Nobody in particular
Requestors:
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.84
Fixed in: (no value)



Subject: security patch for lib\IPC\Run\Win32IO.pm s/INADDR_ANY/$loopback/
Inspired by http://www.perlmonks.org/?node_id=769183 # Firewall complaining about IPC::Run INADDR_ANY can be your external ip, IPC::Run should only listen on localhost Thank you
Subject: patch-IPC-Run-0.84.txt
--- lib\IPC\Run\Win32IO.pm.old 2009-09-14 08:37:16.140625000 -0700 +++ lib\IPC\Run\Win32IO.pm 2009-09-14 08:37:36.343750000 -0700 @@ -393,7 +393,7 @@ { $port = $next_port; $next_port = 2048 if ++$next_port > 65_535; - unless ( bind $listener, sockaddr_in( $port, INADDR_ANY ) ) { + unless ( bind $listener, sockaddr_in( $port, $loopback ) ) { push @errors, "$! on port $port"; croak join "\n", @errors if @errors > 10; goto PORT_FINDER_LOOP;
This patch appears to have been in the code base for a while. Resolving as patched.
On Wed Jun 29 00:29:23 2011, TODDR wrote: Show quoted text
> This patch appears to have been in the code base for a while. > Resolving as patched.
The latest cpan release does not have this patched http://cpansearch.perl.org/src/TODDR/IPC-Run-0.90_02/lib/IPC/Run/Win32IO.pm and neither does http://svn.ali.as/cpan/trunk/IPC-Run/lib/IPC/Run/Win32IO.pm
On Thu Jun 30 03:57:53 2011, noreply wrote: Show quoted text
> On Wed Jun 29 00:29:23 2011, TODDR wrote:
> > This patch appears to have been in the code base for a while. > > Resolving as patched.
> > The latest cpan release does not have this patched > http://cpansearch.perl.org/src/TODDR/IPC-Run-0.90_02/lib/IPC/Run/Win32IO.pm > and neither does > http://svn.ali.as/cpan/trunk/IPC-Run/lib/IPC/Run/Win32IO.pm
You're totally right. I was reading the wrong line. I've got it patched now.
Released in 0.90_03