Bug #49641 for Statistics-Basic: Statistics-Basic 1.6600 FTBFS with perlcritic tests activated

Sat Sep 12 01:35:08 2009 https://launchpad.net/~carnil - Ticket created

Subject:

Statistics-Basic 1.6600 FTBFS with perlcritic tests activated

Hi In Debian we got the following bugreport: http://bugs.debian.org/546227 Statistics-Basic fails to build due failure in perlcritic test: --- Package: libstatistics-basic-perl Version: 1.6600-2 Severity: serious This package fails to build from source on current sid. t/critic........................... # Failed test 'Test::Perl::Critic for "blib/lib/Statistics/Basic.pm"' # at /usr/share/perl5/Test/Perl/Critic.pm line 99. # # Perl::Critic found these violations in "blib/lib/Statistics/Basic.pm": # [Objects::ProhibitIndirectSyntax] Subroutine "new" called using indirect syntax at line 11, column 12. (Severity: 4) # Looks like you failed 1 test of 13. dubious Test returned status 1 (wstat 256, 0x100) DIED. FAILED test 1 Failed 1/13 tests, 92.31% okay Build log attached. -- Niko Tyni ntyni@debian.org --- A full buildlog is attached at the above URL. Bests Salvatore

Sat Sep 12 06:47:55 2009 jettero [...] cpan.org - Correspondence added

Why are you guys running this test? Are you the package author? Unset TEST_AUTHOR and you're all set. I will fix this in two ways. 1) I'll make it so the test won't run unless you're the test author, and then 2) I'll fix the problem -- the problem being perl critic (they are suggestions). -Paul -- If riding in an airplane is flying, then riding in a boat is swimming. 114 jumps, 47.2 minutes of freefall, 90.4 freefall miles.

Sat Sep 12 06:47:56 2009 The RT System itself - Status changed from 'new' to 'open'

Sat Sep 12 07:11:01 2009 salvatore.bonaccorso [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #49641] Statistics-Basic 1.6600 FTBFS with perlcritic tests activated
Date:	Sat, 12 Sep 2009 13:09:16 +0200
To:	Paul Miller via RT <bug-Statistics-Basic [...] rt.cpan.org>
From:	Salvatore Bonaccorso <salvatore.bonaccorso [...] gmail.com>

Hi Paul On Sat, Sep 12, 2009 at 06:47:56AM -0400, Paul Miller via RT wrote: Show quoted text

> Why are you guys running this test? Are you the package author? Unset > TEST_AUTHOR and you're all set. > > I will fix this in two ways. 1) I'll make it so the test won't run > unless you're the test author, and then 2) I'll fix the problem -- the > problem being perl critic (they are suggestions).

No I'm clearly not the author ;-). In Debian pkg-perl team we try always (where applicable) to activate and run all tests when packaging it for the Distribution. Thus Niko detected this when doing a rebuild of Statistics-Basic 1.6600. Yes I know, we can simply skip the author tests, and we are done. I wanted anyway only forward it to you as upstream author. Many thanks for your fast reply and for your work Bests Salvatore

Download signature.asc
application/pgp-signature 836b

Message body not shown because it is not plain text.

Sat Sep 12 07:14:26 2009 jettero [...] cpan.org - Correspondence added

resolved in 1.6601 -- If riding in an airplane is flying, then riding in a boat is swimming. 114 jumps, 47.2 minutes of freefall, 90.4 freefall miles.

Sat Sep 12 07:14:29 2009 jettero [...] cpan.org - Status changed from 'open' to 'resolved'

Sat Sep 12 07:24:15 2009 jettero [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #49641] Statistics-Basic 1.6600 FTBFS with perlcritic tests activated
Date:	Sat, 12 Sep 2009 07:23:29 -0400
To:	Salvatore Bonaccorso via RT <bug-Statistics-Basic [...] rt.cpan.org>
From:	Paul Miller <jettero [...] cpan.org>

On Sat, Sep 12, 2009 at 07:11:03AM -0400, Salvatore Bonaccorso via RT wrote: Show quoted text

> No I'm clearly not the author ;-). In Debian pkg-perl team we try > always (where applicable) to activate and run all tests when packaging > it for the Distribution. Thus Niko detected this when doing a rebuild > of Statistics-Basic 1.6600. Yes I know, we can simply skip the author > tests, and we are done. I wanted anyway only forward it to you as > upstream author.

The problem with this is that all those TEST_AUTHOR tests are set as author tests *because* the frequently fail. The results are meant for the package author *only* and this non-issue really didn't need to become tickets. It didn't help anybody with anything. Show quoted text

> Many thanks for your fast reply and for your work

No problem at all. I enjoy this process ... even this time. Thanks for making debian go vroom. -Paul -- If riding in an airplane is flying, then riding in a boat is swimming. 114 jumps, 47.2 minutes of freefall, 90.4 freefall miles.

Sat Sep 12 07:24:16 2009 The RT System itself - Status changed from 'resolved' to 'open'

Sat Sep 12 07:25:09 2009 jettero [...] cpan.org - Correspondence added

(still resolved, set to open from additional comments. -- If riding in an airplane is flying, then riding in a boat is swimming. 114 jumps, 47.2 minutes of freefall, 90.4 freefall miles.

Sat Sep 12 07:25:19 2009 jettero [...] cpan.org - Status changed from 'open' to 'resolved'