Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CGI CPAN distribution.

Report information
The Basics
Id: 49599
Status: resolved
Priority: 0/
Queue: CGI

People
Owner: Nobody in particular
Requestors: jdhedden [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



Subject: [PATCH] Fix t/fast.t
t/fast.t fails instead of skips if FCGI.pm is not available. The 'use CGI::Fast' needs to be reverted to 'use_ok(CGI::Fast)', and the test counts need to be adjusted accordingly. The attached patch fixes all this.
Subject: cgi.patch
--- CGI.pm-3.47/t/fast.t.orig 2009-09-10 13:10:06.288510500 -0400 +++ CGI.pm-3.47/t/fast.t 2009-09-10 13:11:41.398692700 -0400 @@ -7,16 +7,16 @@ $fcgi = $@ ? 0 : 1; } -use Test::More tests => 10; +use Test::More tests => 11; # Shut up "used only once" warnings. () = $CGI::Q; () = $CGI::Fast::Ext_Request; SKIP: { - skip( 'FCGI not installed, cannot continue', 7 ) unless $fcgi; + skip( 'FCGI not installed, cannot continue', 11 ) unless $fcgi; - use CGI::Fast; + use_ok( CGI::Fast ); ok( my $q = CGI::Fast->new(), 'created new CGI::Fast object' ); is( $q, $CGI::Q, 'checking to see if the object was stored properly' ); is( $q->param(), (), 'no params' );
Subject: Re: [rt.cpan.org #49599] [PATCH] Fix t/fast.t
Date: Thu, 10 Sep 2009 13:23:10 -0400
To: bug-CGI.pm [...] rt.cpan.org
From: Mark Stosberg <mark [...] summersault.com>
Show quoted text
> t/fast.t fails instead of skips if FCGI.pm is not available. The 'use > CGI::Fast' needs to be reverted to 'use_ok(CGI::Fast)', and the test > counts need to be adjusted accordingly.
Thanks. This fix looks reasonable to me. I'll plan to have it appear in the next release with credit to "Jerry D. Hedden" in the Changes file. Let me know if you'd prefer a different credit. Mark
RT-Send-CC: perl5-porters [...] perl.org
On Thu Sep 10 13:23:33 2009, mark@summersault.com wrote: Show quoted text
>
> > t/fast.t fails instead of skips if FCGI.pm is not available. The 'use > > CGI::Fast' needs to be reverted to 'use_ok(CGI::Fast)', and the test > > counts need to be adjusted accordingly.
> > Thanks. This fix looks reasonable to me. I'll plan to have it appear > in the next release with credit to "Jerry D. Hedden" in the Changes file. > Let me know if you'd prefer a different credit. >
I've now upgraded blead with 3.48, but this fix didn't make it, so that test will now fail in smokes. Any chance of a 3.49?
Thanks for the feedback, Steve. I have another attempted fix in my git repo row. Mark
I believe a fix for this was released in the latest 3.49 release that happened today.