Bug #49546 for Image-Info: "substr outside of string" with Fujifilm FinePix S1000fd images

Wed Sep 09 05:45:29 2009 blom [...] cpan.org - Ticket created

Subject:

"substr outside of string" with Fujifilm FinePix S1000fd images

Some (not all) Fujifilm FinePix S1000fd images make Image::TIFF crash with a "substr outside of string" error. Attached you'll find a patch, as well as some tests on two images downloaded from Flickr (http://www.flickr.com/photos/broric85/2908363966/ and http://www.flickr.com/photos/brendanrice/3142774192/) -- B10m

Subject:

fuji_s1000fd.patch

--- /Users/mblom/perl/5.10/lib/Image/TIFF.pm 2009-09-09 09:45:50.000000000 +0200 +++ lib/Image/TIFF.pm 2009-09-09 11:24:29.000000000 +0200 @@ -9,7 +9,7 @@ use strict; use vars qw($VERSION); -$VERSION = '1.06'; +$VERSION = '1.06_01'; my @types = ( [ "BYTE", "C1", 1], @@ -970,7 +970,7 @@ #print STDERR "# Decoding Makernotes from $maker\n"; $self->{tag_prefix} = $tag_prefix; - if ($ifd_off == -1) { + if ($ifd_off == -1 && length($val) >= 12) { # fuji kludge - http://www.butaman.ne.jp/~tsuruzoh/Computer/Digicams/exif-e.html#APP4 my $save_endian = $self->{little_endian}; $self->{little_endian} = 1;

Subject:

Image-Info-tests.tar.gz

Download Image-Info-tests.tar.gz
application/x-tar 4.6m

Message body not shown because it is not plain text.

Wed Sep 09 11:33:12 2009 nospam-abuse [...] bloodgate.com - Correspondence added

Subject:	Re: [rt.cpan.org #49546] "substr outside of string" with Fujifilm FinePix S1000fd images
Date:	Wed, 9 Sep 2009 17:31:05 +0200
To:	bug-Image-Info [...] rt.cpan.org
From:	Tels <nospam-abuse [...] bloodgate.com>

On Wednesday 09 September 2009 11:45:33 M. Blom via RT wrote: Show quoted text

> Wed Sep 09 05:45:29 2009: Request 49546 was acted upon. > Transaction: Ticket created by BLOM > Queue: Image-Info > Subject: "substr outside of string" with Fujifilm FinePix > S1000fd images Broken in: 1.29 > Severity: Important > Owner: Nobody > Requestors: blom@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=49546 > > > > Some (not all) Fujifilm FinePix S1000fd images make Image::TIFF crash > with a "substr outside of string" error. > > Attached you'll find a patch, as well as some tests on two images > downloaded from Flickr > (http://www.flickr.com/photos/broric85/2908363966/ and > http://www.flickr.com/photos/brendanrice/3142774192/)

Sorry, atm I do no longer have time to work on my Perl modules. All the best, Tels -- Signed on Wed Sep 9 17:30:46 2009 with key 0x93B84C15. Get one of my photo posters: http://bloodgate.com/posters PGP key on http://bloodgate.com/tels.asc or per email. "When it's done in 2001." -- 2000 Christmas card about Duke Nukem Forever (http://tinyurl.com/6m8nh)

Download signature.asc
application/pgp-signature 481b

Message body not shown because it is not plain text.

Wed Sep 09 11:33:13 2009 The RT System itself - Status changed from 'new' to 'open'

Mon Sep 14 15:08:48 2009 SREZIC [...] cpan.org - Correspondence added

On Wed Sep 09 05:45:29 2009, BLOM wrote: Show quoted text

> Some (not all) Fujifilm FinePix S1000fd images make Image::TIFF crash > with a "substr outside of string" error. > > Attached you'll find a patch, as well as some tests on two images > downloaded from Flickr > (http://www.flickr.com/photos/broric85/2908363966/ and > http://www.flickr.com/photos/brendanrice/3142774192/)

Thanks, 1.29_51 with your patch is on the way to CPAN and github. I did not include the large sample images because the Image-Info distribution would be too large then. Any change to get smaller test image? Regards, Slaven

Mon Sep 14 15:09:11 2009 SREZIC [...] cpan.org - Status changed from 'open' to 'patched'

Mon Sep 14 15:09:11 2009 SREZIC [...] cpan.org - Fixed in 1.28_51 added

Mon Sep 14 15:09:29 2009 SREZIC [...] cpan.org - Fixed in 1.28_51 deleted

Mon Sep 14 15:20:53 2009 blom [...] cpan.org - Correspondence added

On Mon Sep 14 15:08:48 2009, SREZIC wrote: Show quoted text

> On Wed Sep 09 05:45:29 2009, BLOM wrote:

> > Some (not all) Fujifilm FinePix S1000fd images make Image::TIFF crash > > with a "substr outside of string" error. > > > > Attached you'll find a patch, as well as some tests on two images > > downloaded from Flickr > > (http://www.flickr.com/photos/broric85/2908363966/ and > > http://www.flickr.com/photos/brendanrice/3142774192/)

> > Thanks, 1.29_51 with your patch is on the way to CPAN and github. I did > not include the large sample images because the Image-Info distribution > would be too large then. Any change to get smaller test image?

I have some images that I can't share (business related). After browsing Flickr, I found out it's not just those pictures that cause the error. Will see if I can replicate the behaviour with scaled down images, or find others. -- B10m

Mon Sep 14 15:20:54 2009 The RT System itself - Status changed from 'patched' to 'open'

Mon Sep 14 15:43:06 2009 blom [...] cpan.org - Correspondence added

Resizing the images with Gimp seems to keep the EXIF intact :-) -- B10m

Download Image-Info-tests.tar.gz
application/x-gzip 2.3k

Message body not shown because it is not plain text.

Wed Sep 16 15:26:24 2009 SREZIC [...] cpan.org - Correspondence added

On Mon Sep 14 15:43:06 2009, BLOM wrote: Show quoted text

> Resizing the images with Gimp seems to keep the EXIF intact :-)

Thanks. Now the images are part of the test suite. Regards, Slaven

Wed Sep 16 15:26:44 2009 SREZIC [...] cpan.org - Status changed from 'open' to 'patched'

Sat Oct 31 12:11:21 2009 SREZIC [...] cpan.org - Correspondence added

1.30 is out now. Regards, Slaven

Sat Oct 31 12:11:22 2009 The RT System itself - Status changed from 'patched' to 'open'

Sat Oct 31 12:11:31 2009 SREZIC [...] cpan.org - Status changed from 'open' to 'resolved'