Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 49501
Status: resolved
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: perl [...] galumph.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.108

History Show all quoted text
  Mon Sep 07 18:10:14 2009 perl [...] galumph.com - Ticket created
Subject: From Debian: RequirePackageMatchesPodName: doesn't use nearest package
Date: Mon, 07 Sep 2009 17:09:46 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
This is a copy of the Debian bug report at http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=544063 Package: libperl-critic-perl Version: 1.104-1 Severity: normal I have: -8<- package X::Y::Z; <...> package X::Y::A; =head1 NAME X::Y::A - <...> ->8- The policy Documentation::RequirePackageMatchesPodName complains on that structure.
  Mon Sep 07 18:15:29 2009 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #49501] From Debian: RequirePackageMatchesPodName: doesn't use nearest package
Date: Mon, 07 Sep 2009 17:15:07 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
This policy insists on the first package matching. I see no reason for it to not allow any of the packages in the file to satisfy the requirement. The multiple packages per file policy is separate from this.
  Fri May 07 14:45:46 2010 wyant [...] cpan.org - Correspondence added
Proposed fix committed as SVN update 3806. The patch looks at all package statements rather than the nearest, because of the practice of putting all POD after __END__, rather than in line. There was actually a test that required the code given in the original ticket to fail, but since it seems to be agreed that the code should pass, I have modified the test accordingly, and annotated it with the RT ticket number.
  Fri May 07 14:45:51 2010 The RT System itself - Status changed from 'new' to 'open'
  Sat Oct 09 19:27:53 2010 wyant [...] cpan.org - Status changed from 'open' to 'resolved'
  Sat Oct 09 19:27:54 2010 wyant [...] cpan.org - Fixed in 1.108 added