Skip Menu |

This queue is for tickets about the ExtUtils-MakeMaker CPAN distribution.

Report information
The Basics
Id: 49418
Status: resolved
Priority: 0/
Queue: ExtUtils-MakeMaker
People
Owner: Nobody in particular
Requestors: kmx [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 6.55_02
Fixed in: 6.99_06
Attachments
ExtUtils-MakeMaker-6.55_02-v3.patch
ExtUtils-MakeMaker-6.55_02_v2.diff.gz

History Show all quoted text
  Fri Sep 04 00:15:12 2009 kmx [...] cpan.org - Ticket created
Subject: [PATCH] Handling spaces in path to perl install dir
Hi, please have a look at the following patch: http://svn.ali.as/cpan/users/kmx/perl-modules-patched/ExtUtils-MakeMaker-6.55_02.diff It tries to handle a situation when user has installed his/her perl into a directory with name contains spaces. Currently available version ExtUtils-MakeMaker-6.55_02 generates in such a situation a Makefile that does not work well as it simply does not use enough double quotes around values containing full path to files and/or dirs with spaces in their names. I have tested this patch just Win32/strawberry perl but it should not harm MakeMaker functionality for any other platform. Thanks in advance for considering the proposed patch. -- kmx
  Fri Sep 04 16:05:53 2009 kmx [...] cpan.org - Correspondence added
Improved patch: http://svn.ali.as/cpan/users/kmx/perl-modules-patched/ExtUtils-MakeMaker-6.55_02_v2.diff Now all tests pass - tested on Win32/strawberry perl installed in a dir with spaces in its name. -- kmx
  Fri Sep 04 16:05:58 2009 kmx [...] cpan.org - Status changed from 'new' to 'open'
  Fri Sep 04 21:34:30 2009 schwern [...] pobox.com - Correspondence added
Subject: Re: [rt.cpan.org #49418] [PATCH] Handling spaces in path to perl install dir
Date: Fri, 04 Sep 2009 18:34:09 -0700
To: bug-ExtUtils-MakeMaker [...] rt.cpan.org
From: Michael G Schwern <schwern [...] pobox.com>
kmx via RT wrote: Show quoted text
> Improved patch: > http://svn.ali.as/cpan/users/kmx/perl-modules-patched/ExtUtils-MakeMaker-6.55_02_v2.diff > > Now all tests pass - tested on Win32/strawberry perl installed in a dir > with spaces in its name.
Your first URL is missing. The second is some C code. Please either attach the patch directly to the ticket or fork the repository on http://github.com/schwern/extutils-makemaker Please keep in mind that the quote operator is different on Windows and Unix. What you want to use is $self->quote_literal(). -- 54. "Napalm sticks to kids" is *not* a motivational phrase. -- The 213 Things Skippy Is No Longer Allowed To Do In The U.S. Army http://skippyslist.com/list/
  Fri Sep 04 22:30:22 2009 csjewell [...] cpan.org - Correspondence added
On Fri Sep 04 21:34:30 2009, schwern@pobox.com wrote: Show quoted text
> kmx via RT wrote:
> > Improved patch: > > http://svn.ali.as/cpan/users/kmx/perl-modules-patched/ExtUtils-
> MakeMaker-6.55_02_v2.diff
> > > > Now all tests pass - tested on Win32/strawberry perl installed in a
> dir
> > with spaces in its name.
> > Your first URL is missing. The second is some C code. Please either > attach > the patch directly to the ticket or fork the repository on > http://github.com/schwern/extutils-makemaker > > Please keep in mind that the quote operator is different on Windows > and Unix. > What you want to use is $self->quote_literal().
Don't ask me why the second one is now C code... (apparently that C code got committed by accident.) The patch is attached as far as I'm able to get it. (I may attempt to fix this up to use the quote_literal method in the near future - that we didn't know. I don't have the time to fix it up within the next week or so, however.) --Curtis

Message body is not shown because it is too large.

  Sat Sep 05 13:04:59 2009 kmx [...] volny.cz - Correspondence added
Subject: Re: [rt.cpan.org #49418] [PATCH] Handling spaces in path to perl install dir
Date: Sat, 05 Sep 2009 19:04:32 +0200
To: bug-ExtUtils-MakeMaker [...] rt.cpan.org
From: kmx <kmx [...] volny.cz>
Show quoted text
> Your first URL is missing. The second is some C code. Please either attach > the patch directly to the ticket or fork the repository on > http://github.com/schwern/extutils-makemaker >
Ops, sorry - it was my fault. Attaching the patch to this RT. Show quoted text
> Please keep in mind that the quote operator is different on Windows and Unix. > What you want to use is $self->quote_literal().
Well, maybe I have not used the right approach but it is not only about quoting commands lauched on OS level it is also about quoting items in prerequisites list (which is not platform dependent). -- kmx
Download ExtUtils-MakeMaker-6.55_02_v2.diff.gz
application/x-gzip 3.5k

Message body not shown because it is not plain text.

  Sat Sep 05 13:06:59 2009 kmx [...] volny.cz - Correspondence added
Subject: Re: [rt.cpan.org #49418] [PATCH] Handling spaces in path to perl install dir
Date: Sat, 05 Sep 2009 19:06:32 +0200
To: bug-ExtUtils-MakeMaker [...] rt.cpan.org
From: kmx <kmx [...] volny.cz>
Show quoted text
> Don't ask me why the second one is now C code... (apparently that C code > got committed by accident.) > >
It was my fault. It is fixed now. -- kmx
  Mon Jul 28 16:41:15 2014 ETJ [...] cpan.org - Correspondence added
I claim this is now obsolete since a) duplicate of RT-448; b) hopefully fixed in https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/pull/105 -> 6.99_06.
  Mon Jul 28 16:41:16 2014 ETJ [...] cpan.org - Fixed in 6.99_06 added
  Mon Jul 28 18:55:02 2014 rt-cpan [...] trout.me.uk - Status changed from 'open' to 'resolved'