Bug #49285 for Crypt-SSLeay: Improved OpenSSL detection on Win32/strawberry perl

Mon Aug 31 10:27:28 2009 kmx [...] cpan.org - Ticket created

Subject:

Improved OpenSSL detection on Win32/strawberry perl

Hi, could you please consider the enclosed patch for Makefile.PL that improves autodetection of openssl installation on Win32? This patch is focused on Win32/strawberry as we are about to add openssl support to the next (October2009) strawberry release (openssl will be installed directly with strawberry). The patch is purely about openssl detection - the module itself works nice even now. Thanks. -- kmx

Subject:

cryptssleay.diff

--- perl-modules\Crypt-SSLeay-0.57_01/Makefile.PL 2008-02-18 14:39:06.000000000 +0100 +++ perl-modules-patched\Crypt-SSLeay-0.57_01/Makefile.PL 2009-08-31 15:48:36.379715800 +0200 @@ -29,7 +29,9 @@ $opt_default = 1; } elsif ($^O eq 'MSWin32') { - @POSSIBLE_SSL_DIRS = 'c:\\openssl'; + push @POSSIBLE_SSL_DIRS, 'c:\\openssl'; + push @POSSIBLE_SSL_DIRS, $Config{prefix}, # strawberry perl + push @POSSIBLE_SSL_DIRS, $Config{prefix}.'\..\c', # strawberry perl } elsif ($^O eq 'VMS') { @POSSIBLE_SSL_DIRS = '/ssl$root';

Tue Sep 01 17:23:43 2009 dland [...] cpan.org - Correspondence added

On Mon Aug 31 10:27:28 2009, KMX wrote: Show quoted text

> Hi, > > could you please consider the enclosed patch for Makefile.PL that > improves autodetection of openssl installation on Win32? > > This patch is focused on Win32/strawberry as we are about to add openssl > support to the next (October2009) strawberry release (openssl will be > installed directly with strawberry). > > The patch is purely about openssl detection - the module itself works > nice even now. > > Thanks.

That's nice, thanks. I'll fold that into the next release. If you want to be credited with a human's name, drop me a line here or at david@landgren.net and I'll add it to the readme. Thanks, David

Tue Sep 01 17:23:44 2009 The RT System itself - Status changed from 'new' to 'open'

Tue Sep 01 17:23:46 2009 dland [...] cpan.org - Given to DLAND

Mon Nov 23 14:57:10 2009 kmx [...] cpan.org - Correspondence added

Hi, I have one little enhancement to this patch - could you please change the Makefile.PL section like this (one more line with $Config{usrinc}): elsif ($^O eq 'MSWin32') { push @POSSIBLE_SSL_DIRS, 'c:\\openssl'; push @POSSIBLE_SSL_DIRS, $Config{usrinc} if (-d $Config{usrinc}); push @POSSIBLE_SSL_DIRS, $Config{prefix}, # strawberry perl push @POSSIBLE_SSL_DIRS, $Config{prefix}.'\..\c', # strawberry perl } Since Strawberry Oct2009 we are using $Config{usrinc} value as a preferred way of getting the compilers's include directory. The other two I would keep for pre-Oct2009 strawberry. Thanks. -- kmx

Mon Nov 23 15:09:22 2009 david [...] landgren.net - Correspondence added

Subject:	Re: [rt.cpan.org #49285] Improved OpenSSL detection on Win32/strawberry perl
Date:	Mon, 23 Nov 2009 21:08:47 +0100
To:	bug-Crypt-SSLeay [...] rt.cpan.org
From:	David Landgren <david [...] landgren.net>

kmx via RT a écrit : Show quoted text

> Queue: Crypt-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=49285 > > > Hi, > > I have one little enhancement to this patch - could you please change > the Makefile.PL section like this (one more line with $Config{usrinc}): > > elsif ($^O eq 'MSWin32') { > push @POSSIBLE_SSL_DIRS, 'c:\\openssl'; > push @POSSIBLE_SSL_DIRS, $Config{usrinc} if (-d $Config{usrinc}); > push @POSSIBLE_SSL_DIRS, $Config{prefix}, # strawberry perl > push @POSSIBLE_SSL_DIRS, $Config{prefix}.'\..\c', # strawberry perl > } > > Since Strawberry Oct2009 we are using $Config{usrinc} value as a > preferred way of getting the compilers's include directory. The other > two I would keep for pre-Oct2009 strawberry. > > Thanks.

I'll get onto this, thanks. David

Sun Aug 08 16:42:13 2010 kmx [...] cpan.org - Correspondence added

Just a note that latest dev version 0.57_02 (which I have just tested in relation to RT 52408) does not contain this fix.

--
kmx

Sun Aug 08 17:32:04 2010 nanis [...] runu.moc.invalid - Correspondence added

Hello: Yup. I am going to include this with a couple of other fixes in 0.57_03. That should happen by Aug 11. Sinan On Sun Aug 08 16:42:13 2010, KMX wrote: Show quoted text

> Just a note that latest dev version 0.57_02 (which I have just tested in > relation to RT 52408) does not contain this fix. > > -- > kmx

Sun Aug 08 17:47:29 2010 kmx [...] cpan.org - Correspondence added

Dne Ne 08.srp.2010 17:32:04, NANIS napsal(a):
Show quoted text

> Hello:
>
> Yup. I am going to include this with a couple of other fixes in 0.57_03.
> That should happen by Aug 11.

That's great.

Sun Aug 08 23:07:57 2010 nanis [...] runu.moc.invalid - Fixed in 0.57_01 deleted

Mon Aug 09 17:41:01 2010 nanis [...] runu.moc.invalid - Correspondence added

I just uploaded 0.57_03. I would appreciate it if you can check if everything still works as expected. http://search.cpan.org/~nanis/Crypt-SSLeay-0.57_03/ Thank you. -- Sinan On Sun Aug 08 17:47:29 2010, KMX wrote: Show quoted text

> Dne Ne 08.srp.2010 17:32:04, NANIS napsal(a):

> > Hello: > > > > Yup. I am going to include this with a couple of other fixes in 0.57_03. > > That should happen by Aug 11.

> > That's great.

Mon Aug 09 17:48:45 2010 nanis [...] runu.moc.invalid - Stolen from DLAND

Tue Aug 10 20:53:39 2010 nanis [...] runu.moc.invalid - Status changed from 'open' to 'resolved'

Tue Aug 10 20:53:39 2010 nanis [...] runu.moc.invalid - Fixed in 0.57_03 added