Skip Menu |

This queue is for tickets about the Catalyst-Runtime CPAN distribution.

Report information
The Basics
Id: 49267
Status: resolved
Priority: 0/
Queue: Catalyst-Runtime

People
Owner: bobtfish [...] bobtfish.net
Requestors: sargie [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: finalize_headers() in Catalyst::Engine::HTTP doesn't check $self->options is true before relying on it
Lines 71-74 of Catalyst::Engine::HTTP: if ( $self->options->{keepalive} && $connection && $connection =~ /^keep-alive$/i ) { If $self->options() returns null (and under Catalyst::Test, in our setup, it appears to), you get a fatal error. Manually patching to check that $self->options() is returning true first fixes this: if ( $self->options && $self->options->{keepalive} && $connection && $connection =~ /^keep-alive$/i ) { Cheers. -P
On Sun Aug 30 23:05:56 2009, SARGIE wrote: Show quoted text
> If $self->options() returns null (and under Catalyst::Test, in our > setup, it appears to), you get a fatal error. Manually patching to check > that $self->options() is returning true first fixes this:
Hi. I'm more than happy to fix this, but someone will come along and break it again unless there's a test. Would it be possible for you to supply a test case for this issue? Also, does it seem to _always_ happen, or is it only in your setup (which means that something is setting the options to undef explicitly somewhere). Cheers t0m
Fixed in r13158, but I still don't know how this is caused :(