Skip Menu |

This queue is for tickets about the ExtUtils-MakeMaker CPAN distribution.

Report information
The Basics
Id: 49043
Status: resolved
Worked: 35 min
Priority: 0/
Queue: ExtUtils-MakeMaker
People
Owner: Nobody in particular
Requestors: ddascalescu+perl [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in:
  • 6.54
  • 6.55_01
  • 6.55_02
Fixed in: 6.75_03

History Show all quoted text
  Wed Aug 26 17:32:26 2009 ddascalescu+perl [...] gmail.com - Ticket created
Subject: pompt() on Windows doesn't remove the \r
On Windows, prompt() malfunctions pretty seriously: If the user just hits Enter, the input is "\r", which will be returned. If the user types something, "\r" will be appended. http://github.com/dandv/extutils-makemaker/commit/ facc9de154130054462f46c1d364f0ecf886a07f fixes that. Would be great if this fix made it onto CPAN, as many SSL-related modules fail to build on Strawberry Perl because they prompt for the path to OpenSSL.
  Sat Aug 29 00:54:52 2009 mschwern [...] cpan.org - Correspondence added
On Wed Aug 26 17:32:26 2009, dandv wrote: Show quoted text
> On Windows, prompt() malfunctions pretty seriously: > > If the user just hits Enter, the input is "\r", which will be returned. > > If the user types something, "\r" will be appended. > > http://github.com/dandv/extutils-makemaker/commit/ > facc9de154130054462f46c1d364f0ecf886a07f fixes that. Would be great if > this fix made it onto CPAN, as many SSL-related modules fail to build > on Strawberry Perl because they prompt for the path to OpenSSL.
Hmm. There should be no need for that patch. chomp() should handle it. This would seem to indicate either a bug in chomp() or something changed $/ or that \n is broken or that $ans is not what we think it is. What is in $ans prior to stripping? What version of Perl is this? What is $/ set to inside prompt()?
  Sat Aug 29 00:54:53 2009 The RT System itself - Status changed from 'new' to 'open'
  Sat Aug 29 02:15:43 2009 ddascalescu+perl [...] gmail.com - Correspondence added
[...] Show quoted text
> chomp() should handle it. > This would seem to indicate either a bug in chomp() or something > changed $/ or that \n is broken > > What version of Perl is this?
With Strawberry Perl 5.10.0.6: c:\> perl -v This is perl, v5.10.0 built for MSWin32-x86-multi-thread chomp.pl below: << use strict; use Data::Dump 'ddx'; my $string = "foo\r\n"; ddx $string; chomp $string; ddx $string; Show quoted text
>>
prints: << c:\> perl "chomp.pl" # chomp.pl:6: "foo\r\n" # chomp.pl:9: "foo\r" Show quoted text
>>
Bug in chomp then? I don't remember ever having had this problem with chomp on Windows in 6+ years of ActivePerl. But then again, I might just not have had code that compared a chomped string with another, and trailing "\r"s on display/output tend to go unnoticed.
  Sun Aug 30 15:17:25 2009 schwern [...] pobox.com - Correspondence added
Subject: Re: [rt.cpan.org #49043] pompt() on Windows doesn't remove the \r
Date: Sun, 30 Aug 2009 12:16:58 -0700
To: bug-ExtUtils-MakeMaker [...] rt.cpan.org
From: Michael G Schwern <schwern [...] pobox.com>
Dan Dascalescu via RT wrote: Show quoted text
>> What version of Perl is this?
> > With Strawberry Perl 5.10.0.6: > > c:\> perl -v > > This is perl, v5.10.0 built for MSWin32-x86-multi-thread > > > chomp.pl below: > << > use strict; > use Data::Dump 'ddx'; > > my $string = "foo\r\n"; > ddx $string; > > chomp $string; > ddx $string; > > prints: > > << > c:\> perl "chomp.pl" > # chomp.pl:6: "foo\r\n" > # chomp.pl:9: "foo\r"
\n changes according to the operating system. It's \015\012 (carriage return, newline) on Windows (do an ASCII dump instead of . "foo\r\n" is effectively "\015\015\012". So chomp() is working fine. You should never have to write "\r\n", "\n" is portable. Using this instead of ddx() should confirm: print join " ", map { ord $_ } split "", $string; You should get 102 111 111 13 13 10 before the chomp and 102 111 111 13 after. A \n alone should be 13 10. Perhaps you're feeding prompt() a \r\n somehow? -- There will be snacks.
  Mon Aug 31 02:48:14 2009 ddascalescu+perl [...] gmail.com - Correspondence added
RT-Send-CC: dagolden [...] cpan.org, adamk [...] cpan.org
Show quoted text
> \n changes according to the operating system. > It's \015\012 (carriage return, newline) on Windows (do an ASCII > dump instead of . "foo\r\n" is effectively "\015\015\012".
I've been working with Perl on Windows XP since cca. 2002 and \n has always been \x0A, with ActivePerl and Strawberry. The script below outputs just "10". print join " ", map { ord $_ } split "", "\n"; Show quoted text
> Perhaps you're feeding prompt() a \r\n somehow?
prompt() does receive a "\r\n", and I just press enter. Adding a few Win32 Perl people in the loop.
  Mon Aug 31 07:06:26 2009 adamk [...] cpan.org - Correspondence added
21:02 Alias So question, what is "\n" on windows 21:03 Alias (stay with me here) :) 21:03 nothingmuch IIRC "that depends" 21:03 Alias uh... 21:04 Alias on what? 21:04 dipsy on what is the kudos based anyway 21:04 nothingmuch perlport/NewLlines 21:04 nothingmuch it says that it's \012 21:04 nothingmuch but that this is translated to/from \015\012 in text mode 21:04 nothingmuch (which IIRC is the default) 21:04 nothingmuch so printing \n will result in something different than what e.g. unpack("H*", "\n") will report the way I parse it 21:05 Alias How have I managed to go this long without noticing :/ 21:05 nothingmuch you probably have a good binmode() habit?
  Mon Aug 31 07:58:43 2009 dagolden [...] cpan.org - Correspondence added
On Mon Aug 31 02:48:14 2009, dandv wrote: Show quoted text
> > \n changes according to the operating system. > > It's \015\012 (carriage return, newline) on Windows (do an ASCII > > dump instead of . "foo\r\n" is effectively "\015\015\012".
> > I've been working with Perl on Windows XP since cca. 2002 and \n has > always been \x0A, with ActivePerl and Strawberry. The script below > outputs just "10". > > print join " ", map { ord $_ } split "", "\n"; >
> > Perhaps you're feeding prompt() a \r\n somehow?
> > prompt() does receive a "\r\n", and I just press enter.
I don't know what the "real world" case is, but most likely, something is setting binmode on STDIN. Run the attached program on Strawberry to see the difference. It would probably be smart for EU::MM::prompt not to rely on chomp alone. See the attached patch for a change to from chomp to s{\015?\012$}{} -- David
#!/usr/bin/env perl use 5.010; use strict; use warnings; use ExtUtils::MakeMaker qw/prompt/; sub prompter { my $resp = prompt("Type something:"); $resp =~ s{\r}{\\r}; say "you said '$resp'"; } prompter(); binmode *STDIN; prompter();
diff --git a/lib/ExtUtils/MakeMaker.pm b/lib/ExtUtils/MakeMaker.pm index 893c0bf..5963aef 100644 --- a/lib/ExtUtils/MakeMaker.pm +++ b/lib/ExtUtils/MakeMaker.pm @@ -179,7 +179,7 @@ sub prompt ($;$) { ## no critic else { $ans = <STDIN>; if( defined $ans ) { - chomp $ans; + $ans =~ s{\015?\012$}{}; } else { # user hit ctrl-D print "\n";
  Mon Aug 31 14:08:16 2009 ddascalescu+perl [...] gmail.com - Correspondence added
Show quoted text
> I don't know what the "real world" case is, but most likely, something > is setting binmode on STDIN.
I had PERLIO set to perlio, but after unsetting that, I get the same results as before. Show quoted text
> Run the attached program on Strawberry to see the difference.
With both SET PERLIO=perlio and SET PERLIO= this is the output: C:\prg\perl\test>perl prompt-test.pl Type something: foo you said 'foo' Type something: foo you said 'foo'
  Mon Aug 31 18:10:00 2009 schwern [...] pobox.com - Correspondence added
Subject: Re: [rt.cpan.org #49043] pompt() on Windows doesn't remove the \r
Date: Mon, 31 Aug 2009 15:09:37 -0700
To: bug-ExtUtils-MakeMaker [...] rt.cpan.org
From: Michael G Schwern <schwern [...] pobox.com>
David Golden via RT wrote: Show quoted text
> I don't know what the "real world" case is, but most likely, something > is setting binmode on STDIN.
Looking through the likely suspects... IPC::Run appears to do that in Win32. Could that be it? Dan, does this happen on every module which uses prompt() or just some? If some, check what's in %INC. Show quoted text
> Run the attached program on Strawberry to see the difference. > > It would probably be smart for EU::MM::prompt not to rely on chomp > alone. See the attached patch for a change to from chomp to s{\015?\012$}{}
I'm not about to go around second guessing every programming mistake someone makes. If something is screwing with STDIN and chomp() is busted something else down the line will break. Rather see it fixed at the source. -- E: "Would you want to maintain a 5000 line Perl program?" d: "Why would you write a 5000 line program?"
  Sun Oct 04 06:40:03 2009 CHORNY [...] cpan.org - Severity Critical changed to Important
  Sun Oct 04 06:40:04 2009 CHORNY [...] cpan.org - Broken in 5.47_01 deleted
  Sun Oct 04 06:40:07 2009 CHORNY [...] cpan.org - Broken in 5.48_01 deleted
  Sun Oct 04 06:40:08 2009 CHORNY [...] cpan.org - Broken in 5.48_03 deleted
  Sun Oct 04 06:40:08 2009 CHORNY [...] cpan.org - Broken in 5.48_04 deleted
  Sun Oct 04 06:40:08 2009 CHORNY [...] cpan.org - Broken in 5.49_01 deleted
  Sun Oct 04 06:40:08 2009 CHORNY [...] cpan.org - Broken in 5.50_01 deleted
  Sun Oct 04 06:40:08 2009 CHORNY [...] cpan.org - Broken in 5.51_01 deleted
  Sun Oct 04 06:40:09 2009 CHORNY [...] cpan.org - Broken in 5.52_01 deleted
  Sun Oct 04 06:40:09 2009 CHORNY [...] cpan.org - Broken in 5.54_01 deleted
  Sun Oct 04 06:40:09 2009 CHORNY [...] cpan.org - Broken in 5.55_01 deleted
  Sun Oct 04 06:40:09 2009 CHORNY [...] cpan.org - Broken in 5.55_02 deleted
  Sun Oct 04 06:40:09 2009 CHORNY [...] cpan.org - Broken in 5.55_03 deleted
  Sun Oct 04 06:40:09 2009 CHORNY [...] cpan.org - Broken in 5.90_01 deleted
  Sun Oct 04 06:40:10 2009 CHORNY [...] cpan.org - Broken in 5.91_01 deleted
  Sun Oct 04 06:40:10 2009 CHORNY [...] cpan.org - Broken in 5.92_01 deleted
  Sun Oct 04 06:40:10 2009 CHORNY [...] cpan.org - Broken in 5.93_01 deleted
  Sun Oct 04 06:40:11 2009 CHORNY [...] cpan.org - Broken in 5.94_01 deleted
  Sun Oct 04 06:40:11 2009 CHORNY [...] cpan.org - Broken in 5.94_02 deleted
  Sun Oct 04 06:40:11 2009 CHORNY [...] cpan.org - Broken in 5.95_01 deleted
  Sun Oct 04 06:40:12 2009 CHORNY [...] cpan.org - Broken in 5.96_01 deleted
  Sun Oct 04 06:40:13 2009 CHORNY [...] cpan.org - Broken in 6.00 deleted
  Sun Oct 04 06:40:13 2009 CHORNY [...] cpan.org - Broken in 6.01 deleted
  Sun Oct 04 06:40:13 2009 CHORNY [...] cpan.org - Broken in 6.02 deleted
  Sun Oct 04 06:40:14 2009 CHORNY [...] cpan.org - Broken in 6.03 deleted
  Sun Oct 04 06:40:15 2009 CHORNY [...] cpan.org - Broken in 6.04 deleted
  Sun Oct 04 06:40:15 2009 CHORNY [...] cpan.org - Broken in 6.05 deleted
  Sun Oct 04 06:40:16 2009 CHORNY [...] cpan.org - Broken in 6.06_01 deleted
  Sun Oct 04 06:40:16 2009 CHORNY [...] cpan.org - Broken in 6.06_02 deleted
  Sun Oct 04 06:40:16 2009 CHORNY [...] cpan.org - Broken in 6.06_03 deleted
  Sun Oct 04 06:40:17 2009 CHORNY [...] cpan.org - Broken in 6.06_04 deleted
  Sun Oct 04 06:40:17 2009 CHORNY [...] cpan.org - Broken in 6.06_05 deleted
  Sun Oct 04 06:40:18 2009 CHORNY [...] cpan.org - Broken in 6.10_01 deleted
  Sun Oct 04 06:40:19 2009 CHORNY [...] cpan.org - Broken in 6.10_02 deleted
  Sun Oct 04 06:40:19 2009 CHORNY [...] cpan.org - Broken in 6.10_03 deleted
  Sun Oct 04 06:40:19 2009 CHORNY [...] cpan.org - Broken in 6.10_04 deleted
  Sun Oct 04 06:40:20 2009 CHORNY [...] cpan.org - Broken in 6.10_05 deleted
  Sun Oct 04 06:40:20 2009 CHORNY [...] cpan.org - Broken in 6.10_06 deleted
  Sun Oct 04 06:40:20 2009 CHORNY [...] cpan.org - Broken in 6.10_07 deleted
  Sun Oct 04 06:40:20 2009 CHORNY [...] cpan.org - Broken in 6.10_08 deleted
  Sun Oct 04 06:40:21 2009 CHORNY [...] cpan.org - Broken in 6.11 deleted
  Sun Oct 04 06:40:21 2009 CHORNY [...] cpan.org - Broken in 6.12 deleted
  Sun Oct 04 06:40:21 2009 CHORNY [...] cpan.org - Broken in 6.13 deleted
  Sun Oct 04 06:40:21 2009 CHORNY [...] cpan.org - Broken in 6.14 deleted
  Sun Oct 04 06:40:21 2009 CHORNY [...] cpan.org - Broken in 6.15 deleted
  Sun Oct 04 06:40:22 2009 CHORNY [...] cpan.org - Broken in 6.16 deleted
  Sun Oct 04 06:40:22 2009 CHORNY [...] cpan.org - Broken in 6.17 deleted
  Sun Oct 04 06:40:22 2009 CHORNY [...] cpan.org - Broken in 6.18 deleted
  Sun Oct 04 06:40:22 2009 CHORNY [...] cpan.org - Broken in 6.19 deleted
  Sun Oct 04 06:40:22 2009 CHORNY [...] cpan.org - Broken in 6.20 deleted
  Sun Oct 04 06:40:22 2009 CHORNY [...] cpan.org - Broken in 6.21 deleted
  Sun Oct 04 06:40:22 2009 CHORNY [...] cpan.org - Broken in 6.21_03 deleted
  Sun Oct 04 06:40:23 2009 CHORNY [...] cpan.org - Broken in 6.22 deleted
  Sun Oct 04 06:40:23 2009 CHORNY [...] cpan.org - Broken in 6.23 deleted
  Sun Oct 04 06:40:23 2009 CHORNY [...] cpan.org - Broken in 6.24 deleted
  Sun Oct 04 06:40:23 2009 CHORNY [...] cpan.org - Broken in 6.24_01 deleted
  Sun Oct 04 06:40:23 2009 CHORNY [...] cpan.org - Broken in 6.25 deleted
  Sun Oct 04 06:40:24 2009 CHORNY [...] cpan.org - Broken in 6.25_01 deleted
  Sun Oct 04 06:40:24 2009 CHORNY [...] cpan.org - Broken in 6.25_02 deleted
  Sun Oct 04 06:40:24 2009 CHORNY [...] cpan.org - Broken in 6.25_03 deleted
  Sun Oct 04 06:40:24 2009 CHORNY [...] cpan.org - Broken in 6.25_04 deleted
  Sun Oct 04 06:40:24 2009 CHORNY [...] cpan.org - Broken in 6.25_05 deleted
  Sun Oct 04 06:40:25 2009 CHORNY [...] cpan.org - Broken in 6.25_06 deleted
  Sun Oct 04 06:40:25 2009 CHORNY [...] cpan.org - Broken in 6.25_07 deleted
  Sun Oct 04 06:40:25 2009 CHORNY [...] cpan.org - Broken in 6.25_08 deleted
  Sun Oct 04 06:40:25 2009 CHORNY [...] cpan.org - Broken in 6.25_09 deleted
  Sun Oct 04 06:40:25 2009 CHORNY [...] cpan.org - Broken in 6.25_10 deleted
  Sun Oct 04 06:40:25 2009 CHORNY [...] cpan.org - Broken in 6.25_11 deleted
  Sun Oct 04 06:40:25 2009 CHORNY [...] cpan.org - Broken in 6.25_12 deleted
  Sun Oct 04 06:40:25 2009 CHORNY [...] cpan.org - Broken in 6.26 deleted
  Sun Oct 04 06:40:25 2009 CHORNY [...] cpan.org - Broken in 6.26_01 deleted
  Sun Oct 04 06:40:25 2009 CHORNY [...] cpan.org - Broken in 6.27 deleted
  Sun Oct 04 06:40:26 2009 CHORNY [...] cpan.org - Broken in 6.28 deleted
  Sun Oct 04 06:40:26 2009 CHORNY [...] cpan.org - Broken in 6.29 deleted
  Sun Oct 04 06:40:26 2009 CHORNY [...] cpan.org - Broken in 6.30 deleted
  Sun Oct 04 06:40:26 2009 CHORNY [...] cpan.org - Broken in 6.30_01 deleted
  Sun Oct 04 06:40:26 2009 CHORNY [...] cpan.org - Broken in 6.30_02 deleted
  Sun Oct 04 06:40:27 2009 CHORNY [...] cpan.org - Broken in 6.30_03 deleted
  Sun Oct 04 06:40:27 2009 CHORNY [...] cpan.org - Broken in 6.30_04 deleted
  Sun Oct 04 06:40:27 2009 CHORNY [...] cpan.org - Broken in 6.31 deleted
  Sun Oct 04 06:40:27 2009 CHORNY [...] cpan.org - Broken in 6.32 deleted
  Sun Oct 04 06:40:27 2009 CHORNY [...] cpan.org - Broken in 6.33 deleted
  Sun Oct 04 06:40:28 2009 CHORNY [...] cpan.org - Broken in 6.34 deleted
  Sun Oct 04 06:40:28 2009 CHORNY [...] cpan.org - Broken in 6.35 deleted
  Sun Oct 04 06:40:28 2009 CHORNY [...] cpan.org - Broken in 6.36 deleted
  Sun Oct 04 06:40:28 2009 CHORNY [...] cpan.org - Broken in 6.37_01 deleted
  Sun Oct 04 06:40:28 2009 CHORNY [...] cpan.org - Broken in 6.37_02 deleted
  Sun Oct 04 06:40:28 2009 CHORNY [...] cpan.org - Broken in 6.37_03 deleted
  Sun Oct 04 06:40:28 2009 CHORNY [...] cpan.org - Broken in 6.38 deleted
  Sun Oct 04 06:40:28 2009 CHORNY [...] cpan.org - Broken in 6.40 deleted
  Sun Oct 04 06:40:29 2009 CHORNY [...] cpan.org - Broken in 6.42 deleted
  Sun Oct 04 06:40:29 2009 CHORNY [...] cpan.org - Broken in 6.43_01 deleted
  Sun Oct 04 06:40:29 2009 CHORNY [...] cpan.org - Broken in 6.44 deleted
  Sun Oct 04 06:40:29 2009 CHORNY [...] cpan.org - Broken in 6.45_01 deleted
  Sun Oct 04 06:40:29 2009 CHORNY [...] cpan.org - Broken in 6.45_02 deleted
  Sun Oct 04 06:40:30 2009 CHORNY [...] cpan.org - Broken in 6.46 deleted
  Sun Oct 04 06:40:30 2009 CHORNY [...] cpan.org - Broken in 6.47_01 deleted
  Sun Oct 04 06:40:30 2009 CHORNY [...] cpan.org - Broken in 6.47_02 deleted
  Sun Oct 04 06:40:30 2009 CHORNY [...] cpan.org - Broken in 6.48 deleted
  Sun Oct 04 06:40:31 2009 CHORNY [...] cpan.org - Broken in 6.49_01 deleted
  Sun Oct 04 06:40:31 2009 CHORNY [...] cpan.org - Broken in 6.50 deleted
  Sun Oct 04 06:40:31 2009 CHORNY [...] cpan.org - Broken in 6.51_01 deleted
  Sun Oct 04 06:40:31 2009 CHORNY [...] cpan.org - Broken in 6.51_02 deleted
  Sun Oct 04 06:40:31 2009 CHORNY [...] cpan.org - Broken in 6.51_03 deleted
  Sun Oct 04 06:40:31 2009 CHORNY [...] cpan.org - Broken in 6.51_04 deleted
  Sun Oct 04 06:40:31 2009 CHORNY [...] cpan.org - Broken in 6.52 deleted
  Sun Oct 04 06:40:32 2009 CHORNY [...] cpan.org - Broken in 6.53_01 deleted
  Sun Oct 04 06:40:32 2009 CHORNY [...] cpan.org - Broken in 6.53_02 deleted
  Sun Oct 04 06:40:32 2009 CHORNY [...] cpan.org - Broken in 6.53_03 deleted
  Fri Nov 20 00:27:48 2009 mschwern [...] cpan.org - Correspondence added
Dan, any info?
  Fri Nov 20 00:27:51 2009 mschwern [...] cpan.org - Status changed from 'open' to 'stalled'
  Thu Aug 29 12:07:33 2013 BINGOS [...] cpan.org - Correspondence added 30 min
Applied Dave's change. Patched in repository.
  Thu Aug 29 12:07:33 2013 The RT System itself - Status changed from 'stalled' to 'open'
  Thu Aug 29 12:07:34 2013 BINGOS [...] cpan.org - Status changed from 'open' to 'patched'
  Fri Sep 06 09:38:25 2013 BINGOS [...] cpan.org - Correspondence added 5 min
Stable release 6.76 is now on CPAN.
  Fri Sep 06 09:38:26 2013 BINGOS [...] cpan.org - Status changed from 'patched' to 'resolved'
  Fri Sep 06 09:38:26 2013 BINGOS [...] cpan.org - Fixed in 6.75_03 added