Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 48986
Status: resolved
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: daxim [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.104
Fixed in: 1.108



Subject: t/20_policy_pod_spelling.t test failure in non-English locale
Due to use of magic numbers that have gone out of sync, t/20_policy_pod_spelling.t fails in non-English locales. Attached patch fixes that. It applies cleanly against SVN r3613 with the command patch -p0 < t-20_policy_pod_spelling-t.patch
Subject: t-20_policy_pod_spelling-t.patch
--- t/20_policy_pod_spelling.t +++ t/20_policy_pod_spelling.t @@ -17,7 +17,9 @@ use Perl::Critic::TestUtils qw(pcritique); -use Test::More tests => 5; +use Test::More; +my $COUNT_TESTS = 5; # used again later +plan tests => $COUNT_TESTS; #----------------------------------------------------------------------------- @@ -68,7 +70,7 @@ END_PERL if ( eval { pcritique($policy, \$code) } ) { - skip 'Test environment is not English', 4 + skip 'Test environment is not English', $COUNT_TESTS } #-----------------------------------------------------------------------------
On Tue Aug 25 07:14:27 2009, DAXIM wrote: Show quoted text
> Due to use of magic numbers that have gone out of sync, > t/20_policy_pod_spelling.t fails in non-English locales. Attached patch > fixes that. It applies cleanly against SVN r3613 with the command > patch -p0 < t-20_policy_pod_spelling-t.patch
Thanks (belatedly!) for the patch. Proposed fix (for RT 43291 as well as this) committed as SVN revision 3757.