Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Locale-Maketext CPAN distribution.

Report information
The Basics
Id: 48808
Status: resolved
Priority: 0/
Queue: Locale-Maketext
People
Owner: TODDR [...] cpan.org
Requestors: dmuey [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.15_01
Attachments
Locale-Maketext-1.13_87.tar.gz
rt48808.patch

History Show all quoted text
  Tue Aug 18 10:48:17 2009 dmuey [...] cpan.org - Ticket created
Subject: [1.14 target - item #5] I18N::LangTags use() fixups
Locale::Maketext does this: use I18N::LangTags 0.30 (); presumably because that is when I18N::LangTags::Detect was added and it uses I18N::LangTags::Detect I propose this change which wouldd seem a little saner since 0.30 is many years old (i.e. most people will have it) and is much more explicit about what we actually need: 2 small changes: #1) change: use I18N::LangTags 0.30 (); to use I18N::LangTags (); use I18N::LangTags::Detect (); now we know #2) remove require I18N::LangTags::Detect;
  Tue Aug 18 11:00:51 2009 dmuey [...] cpan.org - Correspondence added
To make it easier to review and implement I've put all changes into a single small patch. This is a complete patch w/ Changelog and version 1.13_86 -> 1.13_87
diff -ruN Locale-Maketext-1.13_86/ChangeLog Locale-Maketext-1.13_87/ChangeLog --- Locale-Maketext-1.13_86/ChangeLog 2009-07-30 14:10:43.000000000 -0500 +++ Locale-Maketext-1.13_87/ChangeLog 2009-08-18 09:57:48.000000000 -0500 @@ -1,5 +1,10 @@ Revision history for Perl suite Locale::Maketext +2009-08-18 Adriano Ferreira + * Development release 1.13_87 + + I18N::LangTags use() fixups (thanks Dan Muey) + 2009-08-04 Adriano Ferreira * Development release 1.13_86 diff -ruN Locale-Maketext-1.13_86/lib/Locale/Maketext.pm Locale-Maketext-1.13_87/lib/Locale/Maketext.pm --- Locale-Maketext-1.13_86/lib/Locale/Maketext.pm 2009-07-30 15:04:16.000000000 -0500 +++ Locale-Maketext-1.13_87/lib/Locale/Maketext.pm 2009-08-18 09:58:25.000000000 -0500 @@ -3,14 +3,15 @@ use vars qw( @ISA $VERSION $MATCH_SUPERS $USING_LANGUAGE_TAGS $USE_LITERALS $MATCH_SUPERS_TIGHTLY); use Carp (); -use I18N::LangTags 0.30 (); +use I18N::LangTags (); +use I18N::LangTags::Detect (); #-------------------------------------------------------------------------- BEGIN { unless(defined &DEBUG) { *DEBUG = sub () {0} } } # define the constant 'DEBUG' at compile-time -$VERSION = '1.13_86'; +$VERSION = '1.13_87'; $VERSION = eval $VERSION; @ISA = (); @@ -380,7 +381,6 @@ ########################################################################### sub _ambient_langprefs { - require I18N::LangTags::Detect; return I18N::LangTags::Detect::detect(); }
  Tue Aug 18 11:00:54 2009 dmuey [...] cpan.org - Status changed from 'new' to 'open'
  Tue Aug 18 11:00:56 2009 dmuey [...] cpan.org - Correspondence added
To make it easier to review and implement I've put all changes into a single small patch. This is a complete patch w/ Changelog and version 1.13_86 -> 1.13_87
diff -ruN Locale-Maketext-1.13_86/ChangeLog Locale-Maketext-1.13_87/ChangeLog --- Locale-Maketext-1.13_86/ChangeLog 2009-07-30 14:10:43.000000000 -0500 +++ Locale-Maketext-1.13_87/ChangeLog 2009-08-18 09:57:48.000000000 -0500 @@ -1,5 +1,10 @@ Revision history for Perl suite Locale::Maketext +2009-08-18 Adriano Ferreira + * Development release 1.13_87 + + I18N::LangTags use() fixups (thanks Dan Muey) + 2009-08-04 Adriano Ferreira * Development release 1.13_86 diff -ruN Locale-Maketext-1.13_86/lib/Locale/Maketext.pm Locale-Maketext-1.13_87/lib/Locale/Maketext.pm --- Locale-Maketext-1.13_86/lib/Locale/Maketext.pm 2009-07-30 15:04:16.000000000 -0500 +++ Locale-Maketext-1.13_87/lib/Locale/Maketext.pm 2009-08-18 09:58:25.000000000 -0500 @@ -3,14 +3,15 @@ use vars qw( @ISA $VERSION $MATCH_SUPERS $USING_LANGUAGE_TAGS $USE_LITERALS $MATCH_SUPERS_TIGHTLY); use Carp (); -use I18N::LangTags 0.30 (); +use I18N::LangTags (); +use I18N::LangTags::Detect (); #-------------------------------------------------------------------------- BEGIN { unless(defined &DEBUG) { *DEBUG = sub () {0} } } # define the constant 'DEBUG' at compile-time -$VERSION = '1.13_86'; +$VERSION = '1.13_87'; $VERSION = eval $VERSION; @ISA = (); @@ -380,7 +381,6 @@ ########################################################################### sub _ambient_langprefs { - require I18N::LangTags::Detect; return I18N::LangTags::Detect::detect(); }
  Tue Aug 18 11:02:07 2009 dmuey [...] cpan.org - Correspondence added
On Tue Aug 18 11:00:56 2009, DMUEY wrote: Show quoted text
> To make it easier to review and implement I've put all changes into a > single small patch. > > This is a complete patch w/ Changelog and version 1.13_86 -> > 1.13_87
A ready-to-upload-via-pause tarball of said patch
Download Locale-Maketext-1.13_87.tar.gz
application/x-gzip 48.4k

Message body not shown because it is not plain text.

  Tue Aug 18 11:02:26 2009 dmuey [...] cpan.org - Subject changed from '[1.14 target - item #5] I18N::LangTags use() fixups' to '[1.14 target - item #5] I18N::LangTags use() fixups (all tests still pass)'
  Wed Feb 03 14:06:27 2010 toddr [...] null.net - Correspondence added
From: toddr [...] null.net
forked perl blead on github - http://github.com/toddr/perl/tree/toddr/maketext-locale will be submitting to P5P post 5.12.0 freeze per advice from jesse Commit: http://github.com/toddr/perl/commit/81e01086442355736cb1435d8568 66069c5cf2ee
  Tue Sep 28 14:19:53 2010 TODDR [...] cpan.org - Correspondence added
Accepted by p5p - commit ed897e29a200fd3c758cb7ab8c0d953347a98056 Author: Todd Rinaldo <toddr@cpan.org> Date: Tue Sep 28 12:19:58 2010 -0500 perl RT# 76668 - This patch resolves CPAN RT #48808. This change: 1. loads I18N::LangTags::Detect in BEGIN rather than whenever _ambient_langprefs is called 2. Removes the version number requirement for I18N::LangTags. Detect didn't come around until 0.31 so a dep on 0.30 is unnecessary. This will assure any load issues with I18N::LangTags::Detect happen at BEGIN, not randomly somewhere in the program. This does increase the dependency on I18N::LangTags from 0.30 to 0.31, but the release dates are as follows, so I don't think it's a big deal: 0.30 - 2004-03-30 Sean M. Burke sburke@cpan.org 0.31 - 2004-06-17 Sean M. Burke sburke@cpan.org
  Tue Oct 05 16:31:43 2010 TODDR [...] cpan.org - Status changed from 'open' to 'patched'
  Tue Oct 05 16:31:43 2010 TODDR [...] cpan.org - Given to TODDR
  Tue Oct 05 16:31:43 2010 TODDR [...] cpan.org - Fixed in 1.15_01 added
  Fri Oct 08 16:13:27 2010 TODDR [...] cpan.org - Correspondence added
1.15_02 is the RC for 1.16. No issues so far. closing ticket.
  Fri Oct 08 16:13:28 2010 The RT System itself - Status changed from 'patched' to 'open'
  Fri Oct 08 16:13:28 2010 TODDR [...] cpan.org - Status changed from 'open' to 'resolved'