Skip Menu |

This queue is for tickets about the SVN-Class CPAN distribution.

Report information
The Basics
Id: 48748
Status: resolved
Priority: 0/
Queue: SVN-Class
People
Owner: Nobody in particular
Requestors: plaven [...] bigpond.net.au
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Sun Aug 16 00:31:29 2009 plaven [...] bigpond.net.au - Ticket created
Subject: Multiple Line commit messages
Date: Sun, 16 Aug 2009 13:02:30 +1000
To: bug-SVN-Class [...] rt.cpan.org
From: Peter Lavender <plaven [...] bigpond.net.au>
Hi, I'm using your module in a project I'm working with and have hit the limit with it when it comes to getting multiple line commit messages to work. The "trick" to this is to save off the text to a text file and specify the file name using either -F or --file option. Looking at the code for the commit method, I can't see a way to get this to work in it's current implementation, apart from some change to the way the $message is checked, ie maybe allow $message to be undef with a requirement that one of the options is either -F or --file in the options array and having a path to a file. Peter.
  Mon Aug 17 21:34:48 2009 peter [...] peknet.com - Correspondence added
Subject: Re: [rt.cpan.org #48748] Multiple Line commit messages
Date: Mon, 17 Aug 2009 20:34:28 -0500
To: bug-SVN-Class [...] rt.cpan.org
From: Peter Karman <peter [...] peknet.com>
plaven@bigpond.net.au via RT wrote on 8/15/09 11:31 PM: Show quoted text
> Sun Aug 16 00:31:29 2009: Request 48748 was acted upon. > Transaction: Ticket created by plaven@bigpond.net.au > Queue: SVN-Class > Subject: Multiple Line commit messages > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: plaven@bigpond.net.au > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=48748 > > > > Hi, > > I'm using your module in a project I'm working with and have hit the > limit with it when it comes to getting multiple line commit messages to > work. > > The "trick" to this is to save off the text to a text file and specify > the file name using either -F or --file option. > > Looking at the code for the commit method, I can't see a way to get this > to work in it's current implementation, apart from some change to the > way the $message is checked, ie maybe allow $message to be undef with a > requirement that one of the options is either -F or --file in the > options array and having a path to a file. >
Hi Peter, Can you just call svn_run() directly, instead of commit()? I understand the limitation you're describing, and you're correct that it would take some significant refactoring to make it work with the existing implementation, which is intended to cover the "most common case" and not much more. OTOH, perhaps you'd consider writing a patch to implement a commit_with_message() method that takes a filehandle or string as an argument and handles the --file option you're wanting? pek -- Peter Karman . http://peknet.com/ . peter@peknet.com gpg key: 37D2 DAA6 3A13 D415 4295 3A69 448F E556 374A 34D9
  Mon Aug 17 21:34:48 2009 The RT System itself - Status changed from 'new' to 'open'
  Wed Aug 19 06:03:56 2009 plaven [...] bigpond.net.au - Correspondence added
Subject: Re: [rt.cpan.org #48748] Multiple Line commit messages
Date: Wed, 19 Aug 2009 20:03:32 +1000
To: bug-SVN-Class [...] rt.cpan.org
From: Peter Lavender <plaven [...] bigpond.net.au>
On Mon, 2009-08-17 at 21:34 -0400, peter@peknet.com via RT wrote: Hi Peter, Happy to have a crack at it... Dumb question though, what's the normal way of doing this? Do I down load the tar ball or is there a repo somewhere to check out the code? Peter Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=48748 >
Show quoted text
> > plaven@bigpond.net.au via RT wrote on 8/15/09 11:31 PM:
> > Sun Aug 16 00:31:29 2009: Request 48748 was acted upon. > > Transaction: Ticket created by plaven@bigpond.net.au > > Queue: SVN-Class > > Subject: Multiple Line commit messages > > Broken in: (no value) > > Severity: (no value) > > Owner: Nobody > > Requestors: plaven@bigpond.net.au > > Status: new > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=48748 > > > > > > > Hi, > > > > I'm using your module in a project I'm working with and have hit the > > limit with it when it comes to getting multiple line commit messages to > > work. > > > > The "trick" to this is to save off the text to a text file and specify > > the file name using either -F or --file option. > > > > Looking at the code for the commit method, I can't see a way to get this > > to work in it's current implementation, apart from some change to the > > way the $message is checked, ie maybe allow $message to be undef with a > > requirement that one of the options is either -F or --file in the > > options array and having a path to a file. > >
> > Hi Peter, > > Can you just call svn_run() directly, instead of commit()? I understand the > limitation you're describing, and you're correct that it would take some > significant refactoring to make it work with the existing implementation, which > is intended to cover the "most common case" and not much more. > > OTOH, perhaps you'd consider writing a patch to implement a > commit_with_message() method that takes a filehandle or string as an argument > and handles the --file option you're wanting? > > pek > >
  Wed Aug 19 09:56:53 2009 peter [...] peknet.com - Correspondence added
Subject: Re: [rt.cpan.org #48748] Multiple Line commit messages
Date: Wed, 19 Aug 2009 08:56:35 -0500
To: bug-SVN-Class [...] rt.cpan.org
From: Peter Karman <peter [...] peknet.com>
plaven@bigpond.net.au via RT wrote on 08/19/2009 05:03 AM: Show quoted text
> Queue: SVN-Class > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=48748 > > > On Mon, 2009-08-17 at 21:34 -0400, peter@peknet.com via RT wrote: > > Hi Peter, > > Happy to have a crack at it... > > > Dumb question though, what's the normal way of doing this? Do I down > load the tar ball or is there a repo somewhere to check out the code? > >
not a dumb question. I really need to get some boilerplate about repos and how to patch into the pod. svn is here: https://svn.msi.umn.edu/sw/perl/ you can reply to this thread with patches, I believe. -- Peter Karman . http://peknet.com/ . peter@peknet.com gpg key: 37D2 DAA6 3A13 D415 4295 3A69 448F E556 374A 34D9
  Thu Aug 20 06:07:58 2009 plaven [...] bigpond.net.au - Correspondence added
Subject: Re: [rt.cpan.org #48748] Multiple Line commit messages
Date: Thu, 20 Aug 2009 20:07:35 +1000
To: bug-SVN-Class [...] rt.cpan.org
From: Peter Lavender <plaven [...] bigpond.net.au>
On Wed, 2009-08-19 at 09:56 -0400, peter@peknet.com via RT wrote: Cool thanks... How do I get perl script to use the Class for testing? Mucking about last night I got something to work using File::Temp, is it OK to add in a new dependancy like this? Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=48748 > > > plaven@bigpond.net.au via RT wrote on 08/19/2009 05:03 AM:
> > Queue: SVN-Class > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=48748 > > > > > On Mon, 2009-08-17 at 21:34 -0400, peter@peknet.com via RT wrote: > > > > Hi Peter, > > > > Happy to have a crack at it... > > > > > > Dumb question though, what's the normal way of doing this? Do I down > > load the tar ball or is there a repo somewhere to check out the code? > > > >
> > not a dumb question. I really need to get some boilerplate about repos > and how to patch into the pod. > > svn is here: > > https://svn.msi.umn.edu/sw/perl/ > > you can reply to this thread with patches, I believe. >
  Thu Aug 20 07:20:56 2009 plaven [...] bigpond.net.au - Correspondence added
Subject: Re: [rt.cpan.org #48748] Multiple Line commit messages
Date: Thu, 20 Aug 2009 21:20:15 +1000
To: bug-SVN-Class [...] rt.cpan.org
From: Peter Lavender <plaven [...] bigpond.net.au>

Message body is not shown because sender requested not to inline it.

On Wed, 2009-08-19 at 09:56 -0400, peter@peknet.com via RT wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=48748 > > > plaven@bigpond.net.au via RT wrote on 08/19/2009 05:03 AM:
> > Queue: SVN-Class > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=48748 > > > > > On Mon, 2009-08-17 at 21:34 -0400, peter@peknet.com via RT wrote: > > > > Hi Peter, > > > > Happy to have a crack at it... > > > > > > Dumb question though, what's the normal way of doing this? Do I down > > load the tar ball or is there a repo somewhere to check out the code? > > > >
> > not a dumb question. I really need to get some boilerplate about repos > and how to patch into the pod. > > svn is here: > > https://svn.msi.umn.edu/sw/perl/
Got it... Show quoted text
> > you can reply to this thread with patches, I believe. >
Well lets see, I'll attach the patch here. It's not great it's just a straight copy of commit() with file handling to set up the command line. I added File::Temp to the Makefile.PL too. It works for the project stuff I was doing. No test though...
  Fri Aug 21 20:36:32 2009 plaven [...] bigpond.net.au - Correspondence added
CC: peter [...] peknet.com
Subject: Re: [rt.cpan.org #48748] Multiple Line commit messages
Date: Sat, 22 Aug 2009 10:36:08 +1000
To: bug-SVN-Class [...] rt.cpan.org
From: Peter Lavender <plaven [...] bigpond.net.au>
On Wed, 2009-08-19 at 09:56 -0400, peter@peknet.com via RT wrote: Hi Peter, I'm not that happy with the patch supplied, it's really more a proof that it works using File::Temp and then using the --file option in the command line. Thinking about it, the commit method could simply use this method of passing a file to the command line as it would also I expect negate the requirement to escape the double and single quotes that would normally break the command line. Peter. Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=48748 > > > plaven@bigpond.net.au via RT wrote on 08/19/2009 05:03 AM:
> > Queue: SVN-Class > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=48748 > > > > > On Mon, 2009-08-17 at 21:34 -0400, peter@peknet.com via RT wrote: > > > > Hi Peter, > > > > Happy to have a crack at it... > > > > > > Dumb question though, what's the normal way of doing this? Do I down > > load the tar ball or is there a repo somewhere to check out the code? > > > >
> > not a dumb question. I really need to get some boilerplate about repos > and how to patch into the pod. > > svn is here: > > https://svn.msi.umn.edu/sw/perl/ > > you can reply to this thread with patches, I believe. >
  Sat Aug 22 14:22:58 2009 karman [...] cpan.org - Correspondence added
brilliant. implemented and uploaded as 0.15 to cpan.
  Sat Aug 22 14:23:00 2009 karman [...] cpan.org - Status changed from 'open' to 'resolved'