Skip Menu |

This queue is for tickets about the OAI-Harvester CPAN distribution.

Report information
The Basics
Id: 48665
Status: resolved
Priority: 0/
Queue: OAI-Harvester

People
Owner: ThB [...] gymel.com
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.13
Fixed in: (no value)



Subject: Makefile.PL fails with XML::SAX::Expat
Makefile.PL seems to fail if XML::SAX::Expat is installed: Checking if your kit is complete... Looks good Writing Makefile for OAI-Harvester Can't locate object method "parsers" via package "XML::SAX" at Makefile.PL line 31. Without XML::SAX::Expat everything's fine. Regards, Slaven
Thanks for the hint: The test logic in Makefile.PL and Build.PL is inverted. Thus if XML::SAX::Expat is NOT installed, there will be NO hint about how advantageous it would be. But either way: The error message about XML::SAX not knowing about its parsers() method is extremly irritating: XML::SAX v0.1 is a prerequisite for the build process, however 0.12 (dating from 2002) is the oldest version I can locate on CPAN. What is your installed version of XML::SAX and might it be broken? Thomas Berger
I see clearer now: The eval { use '...' } clause in Makefile.PL and Build.PL was meant to use XML::SAX (not XML::SAX::Expat) in order to subsequently test for installed parsers. ExtUtils::MakeMaker and Module::Build do not abort if the prerequisite XML::SAX is not met and thus we have to check ourselves.
On Wed Aug 12 17:28:53 2009, THB wrote: Show quoted text
> Thanks for the hint: The test logic in Makefile.PL and Build.PL is > inverted. Thus if XML::SAX::Expat is NOT installed, there will be NO > hint about how advantageous it would be. > > But either way: The error message about XML::SAX not knowing about its > parsers() method is extremly irritating: XML::SAX v0.1 is a prerequisite > for the build process, however 0.12 (dating from 2002) is the oldest > version I can locate on CPAN. What is your installed version of XML::SAX > and might it be broken?
XML::SAX is a requirement, but this requirement is fulfilled by CPAN.pm and CPANPLUS.pm *after* the Makefile.PL was executed. If you really need XML::SAX to be already installed when Makefile.PL is executed, then you have to specify the configure_requires field in META.yml. Regards, Slaven
Subject: Re: [rt.cpan.org #48665] Makefile.PL fails with XML::SAX::Expat
Date: Sun, 16 Aug 2009 18:28:19 +0200
To: bug-OAI-Harvester [...] rt.cpan.org
From: Thomas Berger <ThB [...] Gymel.com>
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi Slaven, Show quoted text
> XML::SAX is a requirement, but this requirement is fulfilled by CPAN.pm > and CPANPLUS.pm *after* the Makefile.PL was executed. If you really need > XML::SAX to be already installed when Makefile.PL is executed, then you > have to specify the configure_requires field in META.yml.
Well, no: It is not really needed, just to check for XML::SAX::ExpatXS via the parser factory. The outcome of this test ist not very interesting in cases where the prerequisite XML::SAX itself is not available, but of course it should not crash Makefile.PL (nor Build.PL). I will consider a change from the current manual test for the module towards configure_requires, maybe Makefile.PL would then become really lean and easy to read. Anyway, the issue is fixed in svn URL: < https://oai-harvester.svn.sourceforge.net/svnroot/oai-harvester/oai-harvester/trunk Show quoted text
>, but at the moment I do not intend to ship Net::OAI::Harvester 1.14 at CPAN
since my impression still is that you encountered a very rare border case. viele Gruesse Thomas Berger -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.3-nr1 (Windows XP) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQCVAwUBSogzomITJZieluOzAQL2WwP/QBGsWsdxEHbbRu2SgMVKb/auX/YPlOm0 HkGVIgse8xZNlb/vqg4fnCxpwTQ4kXXcuekKYwRC2j6vAxofO/8o5mEXHeScIXKm YlUTk+21JmpYe1i0d0WW6FaVXMZMiXjyWtdO1XbtXgfbtVQkAgNVqeFuMSQtwy31 S84tQvCqutU= =CCdt -----END PGP SIGNATURE-----
several 'no' parsers issues should be thoroughly eliminated in 1.14a