Tim,
Show quoted text> I see that you deleted the documentation about problems with commented-
> out select loops not being ignored as they should be; apparently, you
> think that no longer happens. It's been a while since I played with
> this module, so if improvements in the new Filter::Simple and/or
> Text::Balanced have eradicated those bugs, I hadn't noticed! This leads
> me to wonder, how extensive was the testing procedure that you used?
More test programs were prepared:
- 'eslect_fixed' with actually correctly spelled 'select' loop and commented
out
tests ok
- 'loop_variable_names' where loop-variable names look like Perl operators,
tests ok
- 'failure_to_identify_loops' test,
which, as I see it now, doesn't work as expected :) Looks like its
impossible to
test mutiple cases in one file, by the mean of screen dump. Fixing this
(test file)
Show quoted text> I see you caught a bug where A and B or C should have been A and (B or
> C); thanks for that! I didn't understand some of the other changes you
> made, so I'll study them more closely and get back to you.
Also greped the source for all such constructs, only this one was faulty ;)
Show quoted text> This was one thing that confused me: checking !$iscrlf to determine if
> the Reference files had the proper line-endings to justify comparing
> files during testing. The Reference files, being created on Linux, have
> only linefeeds at their ends, so why isn't that test done as (!$islf) ?
Skip file-size tests if current IO layer has newlines type different from
newlines
in the reference files, eg. on 'MSWin32' platform logical '\n' in text files
is stored
as '\x0d\x0a' byte sequence.
Actually I spoted few more bugs:
- can't set 'prompt' option in constructor (working on it)
- nailed down problem in Select.pm around 647 line:
# local scope for $^W mod
# getting one pesky "uninit var" warnings I can't resolve
so puting "use warnings" in Select.pm does not throw warnings any more :)
- $ENV{Select_POSIX_Shell_Prompt} misspelled, should read:
$ENV{Shell_POSIX_Select_prompt}
Plus I've got idea for a new feature in test.pl:
if 'testname.input' file with program input (keystrokes) is present in
Tests_Progs
directory along with 'testname' test file, and we're testing for screens
matches
do stuff the 'testname.input' file to STDIN of the test program and compare
the
output with expected screen dump?
Show quoted text>
> Tim
> P.S. I know very little about the Windows programming environment!
> That's why I didn't attempt to make this module work with it in
> the first place.
Przemek
