| Subject: | minor bug in AnyEvent::SMTPO |
| Date: | Mon, 10 Aug 2009 15:56:22 +0200 |
| To: | bug-AnyEvent-SMTP [...] rt.cpan.org |
| From: | Marc Lehmann <schmorp [...] schmorp.de> |
Hi, I just read through your sources, and found a minor bug:
"MAIL FROM: <$args{from}>"
the syntax for mail from is:
mail from:<reverse-path> options
so you specify the reverse path as an option, and no reverse path. many
mailers support this and try to parse the firts option as reverse path if
none is given, but not all get it right (guessing is always hard), so you
youls really specify the reverse path as the first agrument to the mail
command, not as an option (see rfc5321).
rcpt to: suffers form the same error.
another gripe is:
use AnyEvent; BEGIN { AnyEvent::common_sense }
To me, common sense means _not_ using undocumented private functions from
another module unless you need to. There is a common::sense module with
defined semantics on cpan :)
The fucntion you use can go away at any time, and the more people use
undocumented functions, the more difficult will it be to maintain AnyEvent.
While I cannot stop, it would be nice if you would re-think your decision
here :)
Otherwise, I am quite impressed with your module.
--
The choice of a Deliantra, the free code+content MORPG
-----==- _GNU_ http://www.deliantra.net
----==-- _ generation
---==---(_)__ __ ____ __ Marc Lehmann
--==---/ / _ \/ // /\ \/ / pcg@goof.com
-=====/_/_//_/\_,_/ /_/\_\