Skip Menu |

This queue is for tickets about the MooseX-Types-DateTime-ButMaintained CPAN distribution.

Report information
The Basics
Id: 48485
Status: resolved
Priority: 0/
Queue: MooseX-Types-DateTime-ButMaintained

People
Owner: Nobody in particular
Requestors: zakame [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.08
Fixed in: (no value)



Subject: t/01_basic.t fails on 'bad time zone'
While installing this module as an indirect dependency for Net::Amazon::S3, I encountered this test failure. See attached typescript. Apparently the DateTime::TimeZone I'm using (version 0.93) returns undef instead of returning an exception as documented, so this may very well be a DateTime::TimeZone bug.
Subject: moosex-types-datetime-butmaintained-bug.txt
Script started on Thu Aug 6 15:32:10 2009 $ PERL_AUTOINSTALL=--defaultdeps cpanp -i MooseX::Types::DateTime::ButMaintain i MooseX::Types::DateTime::ButMaintain <ed Installing MooseX::Types::DateTime::ButMaintained (0.08) Running [/usr/bin/perl /usr/bin/cpanp-run-perl /home/zakame/.cpanplus/5.10.0/build/MooseX-Types-DateTime-ButMaintained-0.08/Makefile.PL]... Cannot determine perl version info from lib/MooseX/Types/DateTime/ButMaintained.pm *** Module::AutoInstall version 1.03 *** Checking for Perl dependencies... *** Since we're running under CPANPLUS, I'll just let it take care of the dependency's installation later. [Core Features] - Test::Exception ...loaded. (0.27 >= 0.27) - Test::More ...loaded. (0.92) - Moose ...loaded. (0.88 >= 0.41) - MooseX::Types ...loaded. (0.16 >= 0.04) - namespace::clean ...loaded. (0.11 >= 0.08) - DateTime ...loaded. (0.50 >= 0.4302) - DateTime::Locale ...loaded. (0.43 >= 0.4001) - DateTime::TimeZone ...loaded. (0.93 >= 0.7701) - Olson::Abbreviations ...loaded. (0.02) *** Module::AutoInstall configuration finished. Writing Makefile for MooseX::Types::DateTime::ButMaintained Running [/usr/bin/make test]... PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/01_basic.t t/02_olson_abbreviations.t t/03_local_floating.t # Failed test 'bad time zone' # at t/01_basic.t line 89. # Looks like you failed 1 test of 21. t/01_basic.t ................ Dubious, test returned 1 (wstat 256, 0x100) Failed 1/21 subtests t/02_olson_abbreviations.t .. ok t/03_local_floating.t ....... ok Test Summary Report ------------------- t/01_basic.t (Wstat: 256 Tests: 21 Failed: 1) Failed test: 16 Non-zero exit status: 1 Files=3, Tests=28, 4 wallclock secs ( 0.08 usr 0.04 sys + 3.20 cusr 0.30 csys = 3.62 CPU) Result: FAIL Failed 1/3 test programs. 1/28 subtests failed. *** Error code 255 Stop in /home/zakame/.cpanplus/5.10.0/build/MooseX-Types-DateTime-ButMaintained-0.08 (line 754 of Makefile). [ERROR] MAKE TEST failed: Bad file descriptor PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/01_basic.t t/02_olson_abbreviations.t t/03_local_floating.t # Failed test 'bad time zone' # at t/01_basic.t line 89. # Looks like you failed 1 test of 21. t/01_basic.t ................ Dubious, test returned 1 (wstat 256, 0x100) Failed 1/21 subtests t/02_olson_abbreviations.t .. ok t/03_local_floating.t ....... ok Test Summary Report ------------------- t/01_basic.t (Wstat: 256 Tests: 21 Failed: 1) Failed test: 16 Non-zero exit status: 1 Files=3, Tests=28, 4 wallclock secs ( 0.08 usr 0.04 sys + 3.20 cusr 0.30 csys = 3.62 CPU) Result: FAIL Failed 1/3 test programs. 1/28 subtests failed. *** Error code 255 Stop in /home/zakame/.cpanplus/5.10.0/build/MooseX-Types-DateTime-ButMaintained-0.08 (line 754 of Makefile). The tests for 'MooseX::Types::DateTime::ButMaintained' failed. Would you like me to proceed anyway or should we abort?  Proceed anyway? [y/N]: [ERROR] Unable to create a new distribution object for 'MooseX::Types::DateTime::ButMaintained' -- cannot continue *** Install log written to: /home/zakame/.cpanplus/install-logs/MooseX-Types-DateTime-ButMaintained-0.08-1249544008.log Error installing 'MooseX::Types::DateTime::ButMaintained' Problem installing one or more modules $ cpanp CPANPLUS::Shell::Default -- CPAN exploration and module installation (v0.88) *** Please report bugs to <bug-cpanplus@rt.cpan.org>. *** Using CPANPLUS::Backend v0.88. ReadLine support enabled. *** Type 'p' now to show start up log Did you know... You can run an interactive setup using 's reconfigure'  CPAN Terminal> z MooseX::Types::DateTime::ButMaintained $ ls Changes META.yml Makefile.PL docs lib t MANIFEST Makefile blib inc pm_to_blib $ prove -lv t/01_basic.t t/01_basic.t .. ok 1 - use MooseX::Types::DateTime::ButMaintained; ok 2 - The object isa Moose::Meta::TypeConstraint ok 3 - The object isa Moose::Meta::TypeConstraint ok 4 - The object isa Moose::Meta::TypeConstraint ok 5 - coerced epoch into datetime isa DateTime ok 6 - epoch is correct ok 7 - The object isa DateTime ok 8 - The object isa DateTime ok 9 - constraint ok 10 - coerced from seconds isa DateTime::Duration ok 11 - coerced value ok 12 - coerced from hash isa DateTime::Duration ok 13 - constraint ok 14 - coerced string into time zone object isa DateTime::TimeZone ok 15 - correct time zone not ok 16 - bad time zone # Failed test 'bad time zone' # at t/01_basic.t line 89. ok 17 - coerced from string isa DateTime::Locale::he ok 18 - bad locale name ok 19 - maketext handle isa Some::L10N ok 20 - coerced from maketext isa DateTime::Locale::ja ok 21 - Instantiated object using export types 1..21 # Looks like you failed 1 test of 21. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/21 subtests  Test Summary Report ------------------- t/01_basic.t (Wstat: 256 Tests: 21 Failed: 1)  Failed test: 16  Non-zero exit status: 1 Files=1, Tests=21, 2 wallclock secs ( 0.03 usr 0.03 sys + 1.12 cusr 0.05 csys = 1.23 CPU) Result: FAIL $ ^D Error executing your subshell '/bin/ksh': No such file or directory  CPAN Terminal> Exiting CPANPLUS shell $ perl -V Summary of my perl5 (revision 5 version 10 subversion 0) configuration: Platform: osname=openbsd, osvers=4.6, archname=i386-openbsd uname='openbsd' config_args='-dsE -Dopenbsd_distribution=defined -Dmksymlinks' hint=recommended, useposix=true, d_sigaction=define useithreads=undef, usemultiplicity=undef useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef use64bitint=undef, use64bitall=undef, uselongdouble=undef usemymalloc=n, bincompat5005=undef Compiler: cc='cc', ccflags ='-fno-strict-aliasing -fno-delete-null-pointer-checks -pipe -I/usr/local/include', optimize='-O2', cppflags='-fno-strict-aliasing -fno-delete-null-pointer-checks -pipe -I/usr/local/include' ccversion='', gccversion='3.3.5 (propolice)', gccosandvers='openbsd4.6' intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234 d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12 ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8 alignbytes=4, prototype=define Linker and Libraries: ld='cc', ldflags ='-Wl,-E ' libpth=/usr/lib libs=-lm -lutil -lc perllibs=-lm -lutil -lc libc=/usr/lib/libc.so.51.0, so=so, useshrplib=true, libperl=libperl.so.11.0 gnulibc_version='' Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-R/usr/libdata/perl5/i386-openbsd/5.10.0/CORE' cccdlflags='-DPIC -fPIC ', lddlflags='-shared -fPIC ' Characteristics of this binary (from libperl): Compile-time options: PERL_DONT_CREATE_GVSV PERL_MALLOC_WRAP USE_LARGE_FILES USE_PERLIO Built under OpenBSD %ENV: PERL5LIB="/home/zakame/perl5/lib/perl5:/home/zakame/perl5/lib/perl5/i386-openbsd" PERL_MM_OPT="INSTALL_BASE=/home/zakame/perl5" @INC: /home/zakame/perl5/lib/perl5/i386-openbsd /home/zakame/perl5/lib/perl5 /home/zakame/perl5/lib/perl5/i386-openbsd /usr/libdata/perl5/i386-openbsd/5.10.0 /usr/local/libdata/perl5/i386-openbsd/5.10.0 /usr/libdata/perl5 /usr/local/libdata/perl5 /usr/local/libdata/perl5/site_perl/i386-openbsd /usr/libdata/perl5/site_perl/i386-openbsd /usr/local/libdata/perl5/site_perl /usr/libdata/perl5/site_perl . $ ^D Script done on Thu Aug 6 15:34:36 2009
Can anyone else confirm this bug? I'm not able to.
Show quoted text
> Apparently the DateTime::TimeZone I'm using (version 0.93) returns undef > instead of returning an exception as documented, so this may very well > be a DateTime::TimeZone bug.
.93 is very recent, I'm using .96 and it passes. I didn't write this test, I stole the test from the original MooseX::DateTime. It appears as if this was a DateTime::TimeZone bug, all of the last three versions of ::TZ have related to exceptions and dieing. I'm going to mark as resolved, but *please* reopen if you have .96 -- I'll update Makefile.PL to require it and re-release to cpan to be sure no one has this problem again. (moving under the assumption problem is with ::TZ) 0.96 2009-08-18 - A $SIG{__DIE__} related test in 04local.t behaved differently on different platforms. The test has been narrowed so that it should work the same on all platforms. Reported by Jens Rehsack. 0.95 2009-08-18 - Attempting to load an invalid Olson-style name like "Bad/Name" did throw an error since 0.92. Reported by Florian Ragwitz. - Localized $SIG{__DIE__} for every eval. 0.94 2009-08-17 - This release is based on version 2009j of the Olson database. This release has changes for Egypt. - Localize $SIG{__DIE__} in DateTime::TimeZone::Local, so errors in evals done by that module are not seen by existing __DIE__ handlers. Based on a patch from Jim. RT #48567.
On Wed Aug 19 12:30:27 2009, ECARROLL wrote: Show quoted text
> .93 is very recent, I'm using .96 and it passes. I didn't write this > test, I stole the test from the original MooseX::DateTime. It appears as > if this was a DateTime::TimeZone bug, all of the last three versions of > ::TZ have related to exceptions and dieing. I'm going to mark as > resolved, but *please* reopen if you have .96 -- I'll update Makefile.PL > to require it and re-release to cpan to be sure no one has this problem > again. (moving under the assumption problem is with ::TZ)
Yes, it appears the test passes with the new ::TZ. See attached typescript. Thanks!
Script started on Thu Aug 20 22:12:51 2009 $ cpanp CPANPLUS::Shell::Default -- CPAN exploration and module installation (v0.88) *** Please report bugs to <bug-cpanplus@rt.cpan.org>. *** Using CPANPLUS::Backend v0.88. ReadLine support enabled. *** Type 'p' now to show start up log Did you know... You can use plugins. Type '/plugins' to list available plugins  CPAN Terminal> z MooseX::Types::DateTime::ButMaintained $ perl -MDateTime::TimeZone -Mv5.10 -e'say $DateTime::TimeZone::VERSION' 0.96 $ perl Makefile.PL Cannot determine perl version info from lib/MooseX/Types/DateTime/ButMaintained.pm *** Module::AutoInstall version 1.03 *** Checking for Perl dependencies... *** Since we're running under CPANPLUS, I'll just let it take care of the dependency's installation later. [Core Features] - Test::Exception ...loaded. (0.27 >= 0.27) - Test::More ...loaded. (0.92) - Moose ...loaded. (0.88 >= 0.41) - MooseX::Types ...loaded. (0.16 >= 0.04) - namespace::clean ...loaded. (0.11 >= 0.08) - DateTime ...loaded. (0.50 >= 0.4302) - DateTime::Locale ...loaded. (0.43 >= 0.4001) - DateTime::TimeZone ...loaded. (0.96 >= 0.96) - Olson::Abbreviations ...loaded. (0.02) *** Module::AutoInstall configuration finished. Writing Makefile for MooseX::Types::DateTime::ButMaintained $ make Skip blib/lib/MooseX/Types/DateTime/ButMaintained.pm (unchanged) Manifying blib/man3/MooseX::Types::DateTime::ButMaintained.3p $ make test PERL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/01_basic.t t/02_olson_abbreviations.t t/03_local_floating.t t/01_basic.t ................ t/01_basic.t ................ 1/? t/01_basic.t ................ 19/? t/01_basic.t ................ ok t/02_olson_abbreviations.t .. t/02_olson_abbreviations.t .. 1/4 t/02_olson_abbreviations.t .. ok t/03_local_floating.t ....... t/03_local_floating.t ....... 1/3 t/03_local_floating.t ....... ok All tests successful. Files=3, Tests=28, 4 wallclock secs ( 0.05 usr 0.07 sys + 3.20 cusr 0.15 csys = 3.47 CPU) Result: PASS $ ^D  CPAN Terminal> Exiting CPANPLUS shell $ ^D Script done on Thu Aug 20 22:14:17 2009