Bug #48438 for Net-SSH2: Module dies if connect fails

Wed Aug 05 04:12:04 2009 markusvuori [...] gmail.com - Ticket created

Subject:

Module dies if connect fails

This does NOT work: $ssh2->connect( $host ) or die "Connection cannot be established"; because the die never occurs. Reason: Connect method does not return anything, it just dies (because there's a croak call in the code). Croak should be replaced with 'return undef' or something else, which returns something and let's the calling procedure to catch the error.

Wed Aug 05 06:03:11 2009 dbrobins [...] cpan.org - Correspondence added

Catch it with eval.

Wed Aug 05 06:03:12 2009 The RT System itself - Status changed from 'new' to 'open'

Wed Aug 05 06:03:13 2009 dbrobins [...] cpan.org - Status changed from 'open' to 'rejected'

Wed Aug 05 06:09:39 2009 markus [...] vuoret.net - Correspondence added

Subject:	Re: [rt.cpan.org #48438] Module dies if connect fails
Date:	Wed, 5 Aug 2009 13:08:57 +0300
To:	bug-Net-SSH2 [...] rt.cpan.org
From:	Markus Vuori <markusvuori [...] gmail.com>

Yes, it can be cought with eval. However, it would be nice if the example codes which make use of "connect or die" would work as intended. Regards, MarkusV 2009/8/5 David Robins via RT <bug-Net-SSH2@rt.cpan.org>: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=48438 > > > Catch it with eval. >

Wed Aug 05 06:09:39 2009 The RT System itself - Status changed from 'rejected' to 'open'

Sat Aug 15 07:24:42 2009 rkitover [...] cpan.org - Correspondence added

On Wed Aug 05 06:09:39 2009, markus@vuoret.net wrote: Show quoted text

> Yes, it can be cought with eval. However, it would be nice if the > example codes which make use of "connect or die" would work as > intended.

In 0.22, this will do what you expect: $ssh->connect(...) or die $!; In void context, it will continue to throw an exception: $ssh->connect(...); # <-- this throws exception -- Rafael

Sat Aug 15 07:24:44 2009 rkitover [...] cpan.org - Status changed from 'open' to 'resolved'