Skip Menu |

This queue is for tickets about the Audio-FLAC-Header CPAN distribution.

Report information
The Basics
Id: 48424
Status: resolved
Priority: 0/
Queue: Audio-FLAC-Header

People
Owner: Nobody in particular
Requestors: amphetamachine [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 2.3
Fixed in: (no value)



Subject: Adds Garbage / Mixes Up Tag Order
I've had some problems and annoyances in using this library. First off, it always adds the tag "VENDOR=reference libFLAC 1.2.1 20070917" -- even overwriting it if it was in the tag before it was read, or even specifically assigned in Perl. There is no way whatsoever of overriding this behavior, short of re-writing the module. I can't tell you how annoying this is. Second off, because it uses a hash to internally store the tag values, the tags always get mixed up if they get written to the file again. While this does not necessarily constitute a problem for players recognizing the tag info, it does create a problem if the file was double-Vorbis-tagged: Say I had a file tagged like this: ARTIST=Foo TITLE=Bar ARTIST=Baz Most media players would take the value of the first tag (ARTIST => "Foo") to use as the artist name. But since this library uses a hash to store the tag values, when it read (ARTIST => "Baz"), it would override the value of (ARTIST => "Foo") in the hash. Also, some media players use the policy of "`PERFORMER' or `ARTIST', whichever comes first" and this mixing up of tags would destroy the reliability of previously-tagged files.
I've made changes which will hopefully address your VENDOR string issues in github: http://github.com/dsully/perl-audio-flac- header/commit/25b607f4d8d4f298abeccce4dac63298bf84742d - Better (hopefully) handling of VENDOR string. * Add set_vendor_string method. * Write out vendor string in XS. * Don't hardcode vendor string on read in XS. On the tag ordering issue - I'm not inclined to rewrite the entirety of the comment handling to support ordered tags. Sorry.