Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 48361
Status: resolved
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: ericp [...] activestate.com
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 1.101_003
Fixed in: 1.108

History Show all quoted text
  Fri Jul 31 17:13:26 2009 ericp [...] activestate.com - Ticket created
Subject: Build warnings and error messages for dev version 1.101_003
perl, v5.10.0 built for MSWin32-x86-multi-thread, on MS Vista When I run `perl Makefile.PL', I get this warning: Versions of optional/unlisted/indirect dependencies: ... Readonly::XS = 1.05 Variable "$nest" is not available at (re_eval 46) line 2, <DATA> line 1002. Variable "$nest" is not available at (re_eval 47) line 2, <DATA> line 1002. ... During nmake: ... C:\Perl\bin\perl.exe "-Iblib\arch" "-Iblib\lib" lib/Perl/Critic/PolicySummary.pod.PL lib/Perl/Critic/PolicySummary.pod Generating Perl::Critic::PolicySummary. Variable "$nest" is not available at (re_eval 523) line 2, <DATA> line 1002. Variable "$nest" is not available at (re_eval 524) line 2, <DATA> line 1002. Done. ... C:\Perl\bin\perl.exe "-Iblib\arch" "-Iblib\lib" xt/author /generate_without_optional_dependencies_wrappers.PL xt/author/generated/t/00_modules.t_without_optional_dependencies.t Skipping generating tests because it doesn't look like we're in an author environment. [repeats many times] Show quoted text
> nmake test
t/01_config.t ................................. Variable "$nest" is not available at (re_eval 394) line 2, <DATA> line 1002. t/14_policy_parameters.t ...................... 126/301 Variable "$nest" is not available at (re_eval 514) line 2, <DATA> line 1002. Variable "$nest" is not available at (re_eval 515) line 2, <DATA> line 1002. Show quoted text
> C:\Users\ericp\lab\pm\Perl-Critic-1.101_003>nmake install
Microsoft (R) Program Maintenance Utility Version 6.00.8168.0 Copyright (C) Microsoft Corp 1988-1998. All rights reserved. C:\Perl\bin\perl.exe -MExtUtils::Command -e cp bin/perlcritic blib\script\perlcritic pl2bat.bat blib\script\perlcritic C:\Perl\bin\perl.exe "-Iblib\arch" "-Iblib\lib" xt/author/generate_without_optional_dependencies_wrappers.PL xt/author/generated/t/00_modules.t_without_optional_dependencies.t Going to try it anyway...
  Fri Jul 31 18:15:48 2009 jeff [...] imaginative-software.com - Correspondence added
Subject: Re: [rt.cpan.org #48361] Build warnings and error messages for dev version 1.101_003
Date: Fri, 31 Jul 2009 15:15:25 -0700
To: bug-Perl-Critic [...] rt.cpan.org
From: Jeffrey Thalhammer <jeff [...] imaginative-software.com>
On Jul 31, 2009, at 2:13 PM, ericp@activestate.com via RT wrote: Show quoted text
> Going to try it anyway...
It should still work, but you'll probably get similar warnings when you run Perl::Critic. I don't know the root cause of the problem, but I have observed that on perl-5.10, you *do not* get this warning if Regexp::Parser is not installed. So I suspect the bug is in Regexp::Parser or one of its dependencies. I'm not going to be able to track this down any time soon, so feel free to run with the ball. -Jeff
  Fri Jul 31 18:15:49 2009 The RT System itself - Status changed from 'new' to 'open'
  Fri Jul 31 18:35:07 2009 wyant [...] cpan.org - Correspondence added
On Fri Jul 31 17:13:26 2009, ericp@activestate.com wrote: Show quoted text
> perl, v5.10.0 built for MSWin32-x86-multi-thread, on MS Vista > > When I run `perl Makefile.PL', I get this warning: > Versions of optional/unlisted/indirect dependencies: > ... > Readonly::XS = 1.05 > Variable "$nest" is not available at (re_eval 46) line 2, <DATA> line
1002. Show quoted text
> Variable "$nest" is not available at (re_eval 47) line 2, <DATA> line
1002. Show quoted text
> ...
This looks very much to me like RT 42096, filed against Regexp::Parser about 6 months ago (and not fixed. Sigh.) Would you please try one of the patches found at http://rt.cpan.org/Public/Bug/Display.html?id=42096 and let us know what happens? Tom Wyant
  Fri Jul 31 19:04:07 2009 ericp [...] activestate.com - Correspondence added
The patch fixes the $nest bug. I still get perlcritic telling me that it's skipping generating tests because it thinks I'm not in an author environment. I don't know if I should be concerned about that or not. So far, this dev build is working fine, at least meeting my needs.
  Fri Jul 31 22:16:16 2009 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #48361] Build warnings and error messages for dev version 1.101_003
Date: Fri, 31 Jul 2009 21:15:54 -0500
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
ericp@activestate.com via RT wrote: Show quoted text
> Queue: Perl-Critic > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=48361 > > > The patch fixes the $nest bug. I still get perlcritic telling me that > it's skipping generating tests because it thinks I'm not in an author > environment. I don't know if I should be concerned about that or not.
You should not be concerned. You don't want to run those. I should figure out a way to not even have those looked at from Makefile.PL, since P::C development requires Module::Build.
  Sat Oct 09 18:35:40 2010 wyant [...] cpan.org - Correspondence added
Fixed in Perl::Critic 1.108 by replacing Regexp::Parser (the actual source of the problem) by PPIx::Regexp.
  Sat Oct 09 18:35:56 2010 wyant [...] cpan.org - Status changed from 'open' to 'resolved'
  Sat Oct 09 18:35:56 2010 wyant [...] cpan.org - Fixed in 1.108 added