Skip Menu |

This queue is for tickets about the POE-Component-Client-DNS CPAN distribution.

Report information
The Basics
Id: 48335
Status: resolved
Priority: 0/
Queue: POE-Component-Client-DNS

People
Owner: Nobody in particular
Requestors: frequency [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.04
Fixed in: (no value)



Hi: While upgrading this package for Debian, I came across some build issues. They are seen in PASSing CPAN reports -- for example, http://www.nntp.perl.org/group/perl.cpan.testers/2009/07/msg4826903.html It's this warning: Use of uninitialized value $address in pattern match (m//) at /mnt/i386/var/tmp/CPAN-build/POE-Component-Client-DNS-1.04-gEJk4n/blib/lib/POE/Component/Client/DNS.pm line 514, <HOST> line 32. (You might want to consider using Test::NoWarnings in the future so you get a FAIL instead) Anyway, I have patched this in the Debian package using: --- a/DNS.pm +++ b/DNS.pm @@ -511,6 +511,7 @@ s/^\s*//; chomp; my ($address, @aliases) = split; + next unless defined $address; my $type = ($address =~ /:/) ? "AAAA" : "A"; foreach my $alias (@aliases) { $cached_hosts{$alias}{$type}{$address} = 1; And the warnings are gone. Cheers, Jonathan
Thanks again. Your patch and suggestion to use Test::NoWarnings have been committed as revision 83. I'll upload 1.050 to PAUSE shortly.