Skip Menu |

This queue is for tickets about the Catalyst-Plugin-RequireSSL CPAN distribution.

Report information
The Basics
Id: 48328
Status: open
Worked: 30 min
Priority: 0/
Queue: Catalyst-Plugin-RequireSSL

People
Owner: Nobody in particular
Requestors: chisel [...] chizography.net
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.06
Fixed in: (no value)



Subject: Catalyst::Plugin::RequireSSL uses NEXT, which is deprecated
I'm seeing warnings in my test suite where RequireSSL is used: Catalyst::Plugin::RequireSSL uses NEXT, which is deprecated. Please see the Class::C3::Adopt::NEXT documentation for details. NEXT used at /opt/xt/xt-perl/lib/site_perl/5.8.8/Catalyst/Plugin/RequireSSL.pm line 63 I'm running: [Catalyst] 5.80007 [Catalyst::Plugin::RequireSSL] 0.06
Here's a patch against a clean 0.06 that resolves this issue; all tests pass.
diff -Naur Catalyst-Plugin-RequireSSL-0.06/lib/Catalyst/Plugin/RequireSSL.pm Catalyst-Plugin-RequireSSL-0.07/lib/Catalyst/Plugin/RequireSSL.pm --- Catalyst-Plugin-RequireSSL-0.06/lib/Catalyst/Plugin/RequireSSL.pm 2007-03-06 15:45:35.000000000 +0000 +++ Catalyst-Plugin-RequireSSL-0.07/lib/Catalyst/Plugin/RequireSSL.pm 2009-12-22 12:06:26.379484219 +0000 @@ -2,9 +2,9 @@ use strict; use base qw/Class::Accessor::Fast/; -use NEXT; +use MRO::Compat; -our $VERSION = '0.06'; +our $VERSION = '0.07'; __PACKAGE__->mk_accessors( qw/_require_ssl _ssl_strip_output/ ); @@ -30,7 +30,7 @@ # Do not redirect static files (only works with Static::Simple) if ( $c->isa( "Catalyst::Plugin::Static::Simple" ) ) { - return $c->NEXT::finalize(@_) if $c->_static_file; + return $c->next::method(@_) if $c->_static_file; } # redirect back to non-SSL mode @@ -54,13 +54,13 @@ $c->res->body( '' ); } - return $c->NEXT::finalize(@_); + return $c->next::method(@_); } sub setup { my $c = shift; - $c->NEXT::setup(@_); + $c->next::method(@_); # disable the plugin when running under certain engines which don't # support SSL