Skip Menu |

This queue is for tickets about the Net-Patricia CPAN distribution.

Report information
The Basics
Id: 48234
Status: resolved
Estimated: 1 hour (60 min)
Worked: 1 hour (60 min)
Priority: 0/
Queue: Net-Patricia

People
Owner: PHILIPP [...] cpan.org
Requestors: jtk [...] northwestern.edu
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.15
Fixed in: 1.15_01



Subject: $Revision: $ parsing
The following line: '$Revision: 1.15 $' =~ m/(\d+)\.(\d+)(\.\d+)?/ && ( $VERSION = "$1.$2$3"); $3 is not defined and will produced a warning if warnings are enabled. I usually do something like this: '$Revision: 1.15 $' =~ m{ [\$] Revision: \s+ (\S+) }xms && ( $VERSION = $1 ); John
On Mon Jul 27 09:05:06 2009, JTK wrote: Show quoted text
> The following line: > > '$Revision: 1.15 $' =~ m/(\d+)\.(\d+)(\.\d+)?/ && ( $VERSION =
"$1.$2$3"); Show quoted text
> > $3 is not defined and will produced a warning if warnings are enabled. > I usually do something like this: > > '$Revision: 1.15 $' =~ m{ [\$] Revision: \s+ (\S+) }xms && ( $VERSION > = $1 ); > > John
Changing to: '$Revision: 1.15_01 $' =~ m/(\d+)\.(\d+)(_\d+|)/ && ( $VERSION = "$1.$2$3");
Thanks for the report. Fixed in 1.15_01.