Skip Menu |

This queue is for tickets about the LWP-Protocol-socks CPAN distribution.

Report information
The Basics
Id: 48172
Status: resolved
Worked: 2 hours (120 min)
Priority: 0/
Queue: LWP-Protocol-socks

People
Owner: SCR [...] cpan.org
Requestors: bynari [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)



I've added support for username/password authentication in the above 2 patches. It's used as follows:- $ua->proxy( [ 'http', 'https' ] => 'socks://user:pass@ip:port' ) ; I tried to email the author but I've had no reply in the past couple of weeks so I'm filing a bug report here to get this patched. Thanks, Jeff T. Parsons
Subject: lwp-protocol-socks.pm.patch
9a10 > 100a102,111 > > my ($host, $port, $user, $pass) = ($proxy->host, $proxy->port, $proxy->user, $proxy->pass); > my $authtype ; > > if ( $proxy->user ) { > $authtype = 'userpass' ; > } else { > $authtype = 'none' ; > } > 102a114,116 > Username => $proxy->user, > Password => $proxy->pass, > AuthType => $authtype,
Subject: uri-socks.pm.patch
6a7,29 > sub user { > > my $self = shift ; > > my $old = $self->authority() ; > my ( $user ) = $old =~ /^(.*?):/ ; > > return $user ; > } > > > sub pass { > > my $self = shift ; > my $old = $self->authority() ; > > my ( $pass ) = $old =~ /^.*?:(.*?)\@/ ; > > return $pass ; > > } > >
Subject: URI::userinfo doesn't unescape user:pass
FWIW, it seems as if URI::userinfo returns the /unescaped/ user:pass. This is important in case the user or pass have ':' in them. I've tweaked this to do the appropriate URI::Escape::uri_unescape of user & pass, and will cut a new version soon. -SCR On Fri Jul 24 17:10:26 2009, JTP wrote: Show quoted text
> I've added support for username/password authentication in the above 2 > patches. > > It's used as follows:- > > > $ua->proxy( [ 'http', 'https' ] => 'socks://user:pass@ip:port' ) ; > > I tried to email the author but I've had no reply in the past couple of > weeks so I'm filing a bug report here to get this patched. > > > Thanks, > Jeff T. Parsons
Subject: Resolved in version 1.3
This should be resolved in version 1.3, which I just uploaded