Skip Menu |

This queue is for tickets about the Audio-MPD CPAN distribution.

Report information
The Basics
Id: 48114
Status: resolved
Priority: 0/
Queue: Audio-MPD

People
Owner: jquelin [...] cpan.org
Requestors: davidp [...] preshweb.co.uk
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: (no value)



Subject: Documentation should link to other modules
I think it would be beneficial if the documentation used L<> tags to link to documentation for the other modules within the distribution. For example, something like: Return an Audio::MPD::Common::Stats object Would be nicer as: "Return an L<Audio::MPD::Common::Stats> object" allowing a user browsing the documentation via search.cpan.org or elsewhere to simply hit the link to go to the docs for A::M::C::Stats. What do you think? I'm happy to do this if I have commit access to the repo, or can supply patches.
that's a good idea, and i would gladly accept patches. the main repository is on repo.or.cz (http://repo.or.cz/w/audio-mpd.git) - do you have an account on repo.or.cz? depending on what you prefer: - i can give you push rights on the main repo (and then push in a branch of yours that i'll merge in master) - you can fork it and tell me where to clone your branch, that i will merge in master - i can also move the code on github if you prefer so i'm really open and would welcome any patches / contributions! :-)
On Thu Jul 23 09:49:09 2009, JQUELIN wrote: Show quoted text
> that's a good idea, and i would gladly accept patches. > > the main repository is on repo.or.cz (http://repo.or.cz/w/audio-mpd.git) > - do you have an account on repo.or.cz?
I didn't, but I have now - username bigpresh. Show quoted text
> depending on what you prefer: > - i can give you push rights on the main repo (and then push in a branch > of yours that i'll merge in master) > - you can fork it and tell me where to clone your branch, that i will > merge in master
Whichever is easiest for you. Show quoted text
> - i can also move the code on github if you prefer
Meh, Github looks rather nice, but if you're already developing on repo.or.cz, it's probably easiest for you to stay there - I don't expect you to move your code hosting just to suit me :)
you now have push access to the git repo. use the push url (ssh://repo.or.cz/srv/git/audio-mpd.git) to clone the project. push your changes in a new branch, and request to merge here (or by mail directly). i'll then merge in master and publish a new version...
On Thu Jul 23 10:25:51 2009, JQUELIN wrote: Show quoted text
> you now have push access to the git repo. > > use the push url (ssh://repo.or.cz/srv/git/audio-mpd.git) to clone the > project. > > push your changes in a new branch, and request to merge here (or by mail > directly). i'll then merge in master and publish a new version...
Ah, apologies - I've made & pushed my changes, but I just realised I pushed them to the master, rather than a seperate branch; my apologies, hope this doesn't cause problems for you? I'm still rather a Git newbie, I'm much more au fait with Subversion (although I do want to learn to use Git effectively). Do I also have access to the audio-mpd-common.git repo, to make similar changes there?
no problem. in the future first create a branch of your own: $ git co -m bigpresh then make your changes and commit. then push your branch, either for the first time: $ git push origin HEAD or if the branch has already been pushed: $ git push i've given you push rights to audio-mpd-common. tell me when you're done, so i can push a new release... oh, and don't forget to update changes file to take credit of what you've done! :-)
Just to say I've not forgotten about this; I will find sufficient spare tuits to get this sorted & pushed back soon :)
please note that the official git repository for this project has moved and is now hosted on github, at http://github.com/jquelin/audio-mpd. please create an account there and fork this project to have your own tree, and send pull requests when needed. i removed the rights to push to old repositories on repo.or.cz in order to be sure not to loose your future commits. i pulled the commit you already pushed to audio-mpd. thank you, and sorry for inconvenience.
should be fixed in latest versions. thanks for reporting.