Bug #48068 for Tree-Numbered-Tools: non-sorted serials/parent cause null append error

> Queue: Tree-Numbered-Tools > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=48068 > > > sorry i should have done that myself > > here's a test case for bug #2 > > use Tree::Numbered::Tools; > my $arrayref = [ > [qw(serial parent name url)], > [1, 0, 'ROOT', 'ROOT'], > [2, 3, 'File', 'file.pl'], # notice this one has a parent to the next line > [3, 1, 'File', 'file2.pl'], > ]; > > my $tree = Tree::Numbered::Tools->readArray( > arrayref => $arrayref, > use_column_names => 1, > ); > > > here's a test case for bug #2 > use Tree::Numbered::Tools; > > my $arrayref = [ > [qw(serial parent name id)], > [1, 0, 'ROOT', 'ROOT'], > [5, 1, 'File', '5'], > [2, 1, 'File', '2'], > [4, 2, 'File', '4'], > [3, 4, 'File', '3'], > ]; > > my $tree = Tree::Numbered::Tools->readArray( > arrayref => $arrayref, > use_column_names => 1, > ); > > > print $tree->outputFile(); > > > > note that this one succeeds, but the tree is wrong. the output is > # > name id > # ---- -- > File 5 > File 4 > File 3 > File 2 > > whereas ID 4 should have parent ID 2, but since it looks for Tree::Numbered's serial, it attaches to ID 5 (which is placed second in the list) > > > > and here's another test. it's not the exact description of bug #1, but I believe it's related, since id 5 doesn't exist according to Tree::Numbered's serial, the getSubTree() call fails on parentid 5 > > use Tree::Numbered::Tools; > > my $arrayref = [ > [qw(serial parent name id)], > [1, 0, 'ROOT', 'ROOT'], > [5, 1, 'File', '5'], > [8, 5, 'File', '8'], > ]; > > my $tree = Tree::Numbered::Tools->readArray( > arrayref => $arrayref, > use_column_names => 1, > ); > > > print $tree->outputFile(); > > > > -- > Daniel Higgins > Technical Representative > E2E Resolutions Inc. > Phone: +1 (450) 926-8497 x2239 > E-Mail: daniel.higgins@e2eresolutions.com > web : http://www.e2eresolutions.com/ > > -----Message d'origine----- > De : Johan Kuuse via RT [mailto:bug-Tree-Numbered-Tools@rt.cpan.org] > Envoyé : July 22, 2009 2:35 AM > À : danielh@e2eresolutions.com > Objet : Re: [rt.cpan.org #48068] > > <URL: http://rt.cpan.org/Ticket/Display.html?id=48068 > > > On Tue, 2009-07-21 at 15:01 -0400, Daniel Higgins via RT wrote: > > Thanks for the patch. > I'll try to reproduce the error, apply your patch, and then see how I > can fix the other calls to getSubTree(). > > Regards, > Johan > > > > -- > Ce message a t vrifi par MailScanner pour des virus ou des polluriels et rien de > suspect n'a t trouv. > -- > This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean. > > >

> Queue: Tree-Numbered-Tools > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=48068 > > > the original bugs are fixed as far as i can tell, one comment and one one minor issue came up > > 1. it now "requires" version 5.8.9 of perl, but runs fine under 5.8.8 > 2. the addition of "use warnings" causes one to show up on line 1480 if your sql string begin or end with a newline > > -- > Daniel Higgins > Technical Representative > E2E Resolutions Inc. > Phone: +1 (450) 926-8497 x2239 > E-Mail: daniel.higgins@e2eresolutions.com > web : http://www.e2eresolutions.com/ >