Bug #48048 for DBD-SQLite: improper "require utf8" in tests

Tue Jul 21 06:11:25 2009 DAMI [...] cpan.org - Ticket created

Subject:

improper "require utf8" in tests

Tests "33_non_latin_path.t" and "rt_25924_user_defined_func_unicode.t" invoke the "utf8" pragma. However, according to the doc, this pragma is supposed to be used only if the source code is in utf8, which is not the case here. So it is quite likely that accented characters in those tests are misinterpreted, and that the tests nevertheless pass by mere accident. Note : the tests invoke "utf8::upgrade(...)", but this function is always available, doesn't need any "require utf8" or "use utf8".

Sat Sep 01 09:11:54 2012 ishigaki [...] cpan.org - Correspondence added

Removed "(use|require) utf8" from the trunk. Thanks. On Tue Jul 21 19:11:25 2009, DAMI wrote: Show quoted text

> Tests "33_non_latin_path.t" and "rt_25924_user_defined_func_unicode.t" > invoke the "utf8" pragma. However, according to the doc, this pragma

is Show quoted text

> supposed to be used only if the source code is in utf8, which is not

the Show quoted text

> case here. So it is quite likely that accented characters in those

tests Show quoted text

> are misinterpreted, and that the tests nevertheless pass by mere

accident. Show quoted text

> > Note : the tests invoke "utf8::upgrade(...)", but this function is > always available, doesn't need any "require utf8" or "use utf8".

Sat Sep 01 09:11:55 2012 The RT System itself - Status changed from 'new' to 'open'

Sat Sep 01 09:11:55 2012 ishigaki [...] cpan.org - Status changed from 'open' to 'patched'

Mon Sep 24 15:07:46 2012 ishigaki [...] cpan.org - Correspondence added

DBD::SQLite 1.38_01 with this fix is released. Thanks. On Sat Sep 01 22:11:54 2012, ISHIGAKI wrote: Show quoted text

> Removed "(use|require) utf8" from the trunk. Thanks. > > On Tue Jul 21 19:11:25 2009, DAMI wrote:

> > Tests "33_non_latin_path.t" and

"rt_25924_user_defined_func_unicode.t" Show quoted text

> > invoke the "utf8" pragma. However, according to the doc, this

pragma Show quoted text

> is

> > supposed to be used only if the source code is in utf8, which is

not Show quoted text

> the

> > case here. So it is quite likely that accented characters in those

> tests

> > are misinterpreted, and that the tests nevertheless pass by mere

> accident.

> > > > Note : the tests invoke "utf8::upgrade(...)", but this function is > > always available, doesn't need any "require utf8" or "use utf8".

> >

Mon Sep 24 15:07:47 2012 The RT System itself - Status changed from 'patched' to 'open'

Mon Sep 24 15:07:47 2012 ishigaki [...] cpan.org - Status changed from 'open' to 'resolved'