Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 48004
Status: resolved
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: LIMAONE [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Wishlist
Broken in:
  • 1.109
  • 1.111
Fixed in:
  • 1.110_001
  • 1.112_001
  • 1.112_002
  • 1.113

History Show all quoted text
  Sun Jul 19 06:34:43 2009 LIMAONE [...] cpan.org - Ticket created
Subject: CodeLayout::RequireTidyCode and missing Perl::Tidy
Hi, I think policies shouldn't turn off themselves silently if some dependencies are not installed - at least not at higher verbosity levels. A warning such as "Policy CodeLayout::RequireTidyCode deactivated because Perl::Tidy is not installed. Install Perl::Tidy or set [-CodeLayout::RequireTidyCode] to deactivate this policy." would be helpful. The author might not be aware that this policy exists and Test::Perl::Critic might fail if an user has the dependency installed. Thanks again for all your work on Perl::Critic! Markus
  Mon Sep 14 18:52:02 2009 thaljef [...] cpan.org - Correspondence added
On Sun Jul 19 06:34:43 2009, LIMAONE wrote: Show quoted text
> I think policies shouldn't turn off themselves silently if some > dependencies are not installed - at least not at higher verbosity > levels.
Thanks for the suggestion. I'll put this on the TODO list. For what it's worth, Perl-Critic does warn you about missing optional dependencies when you build/install it. Show quoted text
> Test::Perl::Critic might fail if an user has the dependency installed.
We always recommend that you NOT ship any Perl-Critic tests in your distribution, or at least disable them by default. As you pointed out, there's no way of knowing what Policies someone has installed. And you don't want your distro's tests to fail just because of that. We see Perl-Critic as an author-only test.
  Mon Sep 14 18:52:03 2009 The RT System itself - Status changed from 'new' to 'open'
  Tue Dec 07 11:30:18 2010 wyant [...] cpan.org - Correspondence added
I'm going to call this patched, since Perl::Tidy is no longer optional starting with Perl::Critic 1.110_001.
  Tue Dec 07 11:30:18 2010 wyant [...] cpan.org - Status changed from 'open' to 'patched'
  Tue Dec 07 11:30:29 2010 wyant [...] cpan.org - Fixed in 1.110_001 added
  Tue Jan 04 20:58:45 2011 wyant [...] cpan.org - Broken in 1.109 added
  Tue Jan 04 20:58:45 2011 wyant [...] cpan.org - Broken in 1.111 added
  Tue Jan 04 20:58:45 2011 wyant [...] cpan.org - Fixed in 1.112_001 added
  Tue Feb 15 19:32:52 2011 wyant [...] cpan.org - Fixed in 1.112_002 added
  Tue Feb 15 19:32:52 2011 wyant [...] cpan.org - Fixed in 1.113 added
  Wed Feb 23 11:21:22 2011 wyant [...] cpan.org - Status changed from 'patched' to 'resolved'