Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Test-Prereq CPAN distribution.

Report information
The Basics
Id: 4775
Status: resolved
Worked: 5 min
Priority: 0/
Queue: Test-Prereq

People
Owner: bdfoy [...] cpan.org
Requestors: sagarshah [...] softhome.net
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Subroutine redefined warnings from Test::Prereq
From: Sagar Shah <sagarshah [...] softhome.net>
To: bug-test-prereq [...] rt.cpan.org
Date: Sun, 28 Dec 2003 21:06:33 +0000
Show quoted text
-----Forwarded Message----- From: Sagar Shah <sagarshah@softhome.net> To: bdfoy@cpan.org Subject: Test::Distribution and Test::Prereq Date: Sat, 27 Dec 2003 21:15:21 +0000 [snip] When i add a 00_prereq.t to one of my non-Module::Build-using modules: $ cat t/00_prereq.t use Test::Prereq; prereq_ok($]); $ make -f Makefile test PERL_DL_NONLAZY=1 /sbcimp/run/pd/perl/5.8.1/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00_prereq..........Subroutine ExtUtils::MakeMaker::WriteMakefile redefined at /home/shahsag/my_tree/links/cpan/lib/Test/Prereq.pm line 103. Subroutine Test::Prereq::WriteMakefile redefined at /home/shahsag/my_tree/links/cpan/lib/Test/Prereq.pm line 259 My toolchain is: perl 5.8.1 Test::Prereq 0.19 Test::More 0.47 ExtUtils::MakeMaker 6.21 A make test of Test::Prereq itself gives: ==== PERL_DL_NONLAZY=1 /sbcimp/run/pd/perl/5.8.1/bin/perl "-MTest::Manifest" "-e" "run_t_manifest(0, 'blib/lib', 'blib/arch')" Test::Manifest::test_harness found [t/load.t t/pod.t t/import.t t/get_from_file.t t/get_prereqs.t t/get_from_prereqs.t t/get_loaded_modules.t t/prereq_ok.t] t/load..................Subroutine ExtUtils::MakeMaker::WriteMakefile redefined at /home/shahsag/.cpan/build/Test-Prereq-0.19/blib/lib/Test/Prereq.pm line 103. Subroutine main::prereq_ok redefined at /sbcimp/run/pd/perl/5.8.1/lib/Exporter.pm line 60. at (eval 35) line 3 t/load..................ok t/pod...................# NOTE: pod_ok() is deprecated # NOTE: pod_ok() is deprecated t/pod...................ok t/import................ok 1/4Subroutine ExtUtils::MakeMaker::WriteMakefile redefined at /home/shahsag/.cpan/build/Test-Prereq-0.19/blib/lib/Test/Prereq.pm line 103. t/import................ok t/get_from_file.........Subroutine ExtUtils::MakeMaker::WriteMakefile redefined at /home/shahsag/.cpan/build/Test-Prereq-0.19/blib/lib/Test/Prereq.pm line 103. t/get_from_file.........ok t/get_prereqs...........Subroutine ExtUtils::MakeMaker::WriteMakefile redefined at /home/shahsag/.cpan/build/Test-Prereq-0.19/blib/lib/Test/Prereq.pm line 103. Subroutine main::prereq_ok redefined at /sbcimp/run/pd/perl/5.8.1/lib/Exporter.pm line 60. at t/get_prereqs.t line 8 Subroutine Test::Prereq::WriteMakefile redefined at /home/shahsag/.cpan/build/Test-Prereq-0.19/blib/lib/Test/Prereq.pm line 259 Subroutine ExtUtils::MM_Any::test_via_harness redefined at ./Makefile.PL line 5.t/get_prereqs...........ok t/get_from_prereqs......Subroutine ExtUtils::MakeMaker::WriteMakefile redefined at /home/shahsag/.cpan/build/Test-Prereq-0.19/blib/lib/Test/Prereq.pm line 103. This may take awhile... t/get_from_prereqs......ok t/get_loaded_modules....Subroutine ExtUtils::MakeMaker::WriteMakefile redefined at /home/shahsag/.cpan/build/Test-Prereq-0.19/blib/lib/Test/Prereq.pm line 103. t/get_loaded_modules....ok t/prereq_ok.............Subroutine ExtUtils::MakeMaker::WriteMakefile redefined at /home/shahsag/.cpan/build/Test-Prereq-0.19/blib/lib/Test/Prereq.pm line 103. Subroutine Test::Prereq::WriteMakefile redefined at /home/shahsag/.cpan/build/Test-Prereq-0.19/blib/lib/Test/Prereq.pm line 259 Subroutine ExtUtils::MM_Any::test_via_harness redefined at ./Makefile.PL line 5.t/prereq_ok.............ok All tests successful. Files=8, Tests=20, 85 wallclock secs (49.47 cusr + 1.99 csys = 51.46 CPU) /usr/bin/make test -- OK ==== Has a change in ExtUtils::MakeMaker brought about this behaviour? Or are certain parts of Test::Prereq in need of a "no warnings 'redefine'" ? I'd appreciate any guidance, as i'm keen to make Test::Distribution Module::Build friendly. Regards Sagar -- Sagar Shah <sagarshah@softhome.net>
I think this is a perl version effect, but I would still like to fix it. At the moment the warnings are harmless, although maybe scary to those who do not know why there is a warning. I will fix this when I get a chance to test it against a couple different perl versions (although I am stuck overseas for a couple of months).
This was fixed some time ago in version 1.025
Subject: Re: [rt.cpan.org #4775] Subroutine redefined warnings from Test::Prereq
Date: Sat, 16 Dec 2006 20:10:20 +0000
To: bug-Test-Prereq [...] rt.cpan.org
From: Sagar Shah <sagarshah [...] softhome.net>
Hi Brian Hope you're well. Still loving the perl reviews, and looking really forward to seeing Mastering Perl in print :) On Sun, 2006-11-12 at 10:39 -0500, brian_d_foy via RT wrote: Show quoted text
> <URL: http://rt.cpan.org/Ticket/Display.html?id=4775 > > > This was fixed some time ago in version 1.025
I've finally gotten around to looking at adding support for Module::Build in Test::Distribution I just tried installing the latest version, and I still get a single re-defined warning from t/load, see below --- CPAN.pm: Going to build B/BD/BDFOY/Test-Prereq-1.031.tar.gz Checking if your kit is complete... Looks good Writing Makefile for Test::Prereq CPAN: YAML loaded ok cp lib/Prereq.pm blib/lib/Test/Prereq.pm cp lib/Build.pm blib/lib/Test/Prereq/Build.pm Manifying blib/man3/Test::Prereq.3 Manifying blib/man3/Test::Prereq::Build.3 /usr/bin/make -- OK Running make test /usr/bin/perl "-MTest::Manifest" "-e" "run_t_manifest(0, 'blib/lib', 'blib/arch', )" Level is Test::Manifest::test_harness found [t/load.t t/pod.t t/pod_coverage.t t/import.t t/prior_plan.t t/get_from_prereqs.t t/get_from_file.t] t/load................ok 1/2Subroutine main::prereq_ok redefined at /sbcimp/build/cpan/Test-Prereq-1.031/blib/lib/Test/Prereq/Build.pm line 52. t/load................ok t/pod.................ok t/pod_coverage........ok t/import..............ok t/prior_plan..........ok t/get_from_prereqs.... This may take awhile... t/get_from_prereqs....ok t/get_from_file.......ok All tests successful. Files=7, Tests=15, 90 wallclock secs (71.48 cusr + 2.37 csys = 73.85 CPU) /usr/bin/make test -- OK Running make install Installing /sbcimp/run/pd/cpan/install/lib/Test/Prereq Installing /sbcimp/run/pd/cpan/install/lib/Test/Prereq/Build.pm Installing /sbcimp/run/pd/cpan/install/man/man3/Test::Prereq.3 Installing /sbcimp/run/pd/cpan/install/man/man3/Test::Prereq::Build.3 Writing /sbcimp/run/pd/cpan/install/lib/auto/Test/Prereq/.packlist Appending installation info to /sbcimp/run/pd/cpan/install/lib/perllocal.pod /usr/bin/make install -- OK --- Thoughts/views? Sagar -- Sagar Shah <sagarshah@softhome.net> Blog: http://sagsshah.livejournal.com/ Web: http://sagar.freeshell.org/
Subject: Re: [rt.cpan.org #4775] Subroutine redefined warnings from Test::Prereq
Date: Sat, 16 Dec 2006 13:16:26 -0800
To: bug-Test-Prereq [...] rt.cpan.org
From: "brian d foy" <brian.d.foy [...] gmail.com>
On 12/16/06, sagarshah@softhome.net via RT <bug-Test-Prereq@rt.cpan.org> wrote: Show quoted text
> > Queue: Test-Prereq > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=4775 >
Show quoted text
> Hope you're well. Still loving the perl reviews, and looking really > forward to seeing Mastering Perl in print :)
I will look into the Test::Prereq::Build problem after the holidays. It's just a warning, but I suspect it's the same problem I fixed in the "normal" version and neglected to carry through to the Build.pm. Thanks, -- brian d foy <brian.d.foy@gmail.com> http://www.pair.com/~comdog/
* Fixed in 1.033. The warning was a test artifact from loading both Test::Prereq and Test::Prereq::Build, which shouldn't ever happen. They both tried to export prereq_ok.