Skip Menu |

This queue is for tickets about the Catalyst-Action-Role-ACL CPAN distribution.

Report information
The Basics
Id: 47740
Status: open
Priority: 0/
Queue: Catalyst-Action-Role-ACL
People
Owner: Nobody in particular
Requestors: bobtfish [...] bobtfish.net
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Thu Jul 09 06:35:55 2009 bobtfish [...] bobtfish.net - Ticket created
Subject: Does not play nicely with Catalyst::Action::REST
Date: Thu, 09 Jul 2009 11:35:02 +0100
To: bug-Catalyst-Action-Role-ACL [...] rt.cpan.org
From: Tomas Doran <bobtfish [...] bobtfish.net>
Hi Catalyst::Action::Role::ACL is incompatible with Catalyst::Action::REST, as they are both action classes. It would be possible to make Catalyst::Action::Role::ACL a 'proper' action role (ala Catalyst::Controller::ActionRole), and then the two modules would be compatible, and could be used together. It would also fix the namespacing of Catalyst::Action::Role::ACL, which I think is confusing, as Catalyst::Action::Role is the hierarchy which is encouraged for Roles (in the Moose Role sense).. I'd like Catalyst::Action::Role::ACL to replace Catalyst::Plugin::Authorization::ACL as the official / tutorial solution for doing this stuff, but I don't want to do that given the current drawbacks with the code.. Would you accept patches to change this (perhaps with a version increment to 1.X, as it would be a breaking change)? Cheers t0m
  Thu Jul 09 06:53:24 2009 bobtfish [...] bobtfish.net - Correspondence added
Having thought about this a little more, Catalyst::Controller::ActionRole already uses Catalyst::ActionRole::XXXX, so the code would be moved to Catalyst::ActionRole::ACL, and the current Catalyst::Action::Role::ACL could remain (but deprecated) to provide backward compatibility for any users currently using it. This gives us the best of both worlds - not breaking existing code, but being able to move forward and make this play nice with other extensions.
  Thu Jul 09 06:53:25 2009 bobtfish [...] bobtfish.net - Status changed from 'new' to 'open'
  Thu Jul 09 11:11:14 2009 converter42 [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #47740] Does not play nicely with Catalyst::Action::REST
Date: Thu, 9 Jul 2009 10:10:47 -0500
To: bug-Catalyst-Action-Role-ACL [...] rt.cpan.org
From: "David P.C. Wollmann" <converter42 [...] gmail.com>
This sounds like a good plan. I'll try to make time to work on this over the weekend. On Thu, Jul 9, 2009 at 5:53 AM, Tomas Doran via RT < bug-Catalyst-Action-Role-ACL@rt.cpan.org> wrote: Show quoted text
> Queue: Catalyst-Action-Role-ACL > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=47740 > > > Having thought about this a little more, > Catalyst::Controller::ActionRole already uses > Catalyst::ActionRole::XXXX, so the code would be moved to > Catalyst::ActionRole::ACL, and the current Catalyst::Action::Role::ACL > could remain (but deprecated) to provide backward compatibility for any > users currently using it. > > This gives us the best of both worlds - not breaking existing code, but > being able to move forward and make this play nice with other extensions. > >