You are absolutely correct. The timing is fortunate as well. I was
about to upload a new version, it now includes your fix (without an
additional release). I have just uploaded 0.32 to CPAN with this fix
and support for new options in the upcoming rsync 2.6.0 release. Details
are in the Changelog and pod documentation.
Thanks for catching the error and reporting it so it can be fixed.
Special thanks for the diff which shows the problem very clearly.
-Lee
Show quoted text> Date: Fri, 26 Dec 2003 14:43:47 -0500 (EST)
> From: Guest via RT <bug-File-Rsync@rt.cpan.org>
> To: "AdminCc of cpan Ticket #4758": ;
> Subject: [cpan #4758] Bug in Rsync.pm when srchost is set
> Reply-To: bug-File-Rsync@rt.cpan.org
> X-RT-Loop-Prevention: cpan
> RT-Ticket: cpan #4758
> Managed-by: RT 2.0.15 (
http://bestpractical.com/rt/)
> RT-Originator:
>
>
> This message about File-Rsync was sent to you by guest <> via rt.cpan.org
>
> Full context and any attached attachments can be found at:
> <URL:
https://rt.cpan.org/Ticket/Display.html?id=4758 >
>
> Looks like there is a problem with operator precedence on lines 441-442. If srchost is set and the source is scalar, the module will ignore the srchost and put quotes around the source even though quote-src is false. Please see the following diff:
>
> 440,442c440,442
> < push @cmd,$merged->{'srchost'}.':'.
> < $merged->{'quote-src'} ? "\"$merged->{'source'}\""
> < : $merged->{'source'};
> ---
> > push @cmd,$merged->{'srchost'}.':' .
> > ($merged->{'quote-src'} ? "\"$merged->{'source'}\""
> > : $merged->{'source'});
--
Lee Eakin - leakin@dfw.nostrum.com
Never play leapfrog with a unicorn.
