Bug #47495 for namespace-autoclean: Test::More should be included as a test

Wed Jul 01 12:14:52 2009 rsrchboy [...] cpan.org - Ticket created

Wed Jul 01 12:14:54 2009 rsrchboy [...] cpan.org - Correspondence added

namespace::autoclean should include Test::More as a test_requires. While Test::More is indeed a core module, some distributions (e.g. Fedora) split core modules out into distinct sub-packages... Adding Test::More as a test_requires will make it easier for automated packaging / build tools to package (and update!) this module. Thanks! :)

Wed Jul 01 12:14:55 2009 The RT System itself - Status changed from 'new' to 'open'

Mon May 03 03:04:19 2010 XSAWYERX [...] cpan.org - Correspondence added

Subject:

[PATCH] Test::More should be included as a test_requires

On Wed Jul 01 12:14:54 2009, RSRCHBOY wrote: Show quoted text

> namespace::autoclean should include Test::More as a test_requires. > > While Test::More is indeed a core module, some distributions (e.g. Fedora) > split core modules out into distinct sub-packages... Adding Test::More as > a test_requires will make it easier for automated packaging / build tools > to package (and update!) this module. > > Thanks! :)

I've included a patch for this. I've also added Sub::Name because it seems like it's requiring it in some test. You can try to eval there and not run the test if it doesn't exist to avoid having it in Makefile.PL, obviously. That is your decision, though. :)

Subject:

makefile.patch

--- Makefile.PL 2010-05-03 09:57:49.320659544 +0300 +++ Makefile.PL.fixed 2010-05-03 09:59:32.523392723 +0300 @@ -18,7 +18,10 @@ 'ExtUtils::MakeMaker' => '6.31' }, 'AUTHOR' => 'Florian Ragwitz <rafl@debian.org>', - 'BUILD_REQUIRES' => {}, + 'BUILD_REQUIRES' => { + 'Sub::Name' => 0, + 'Test::More' => 0, + }, 'ABSTRACT' => 'Keep imports out of your namespace', 'EXE_FILES' => [], 'VERSION' => '0.10',

Fri May 07 13:34:13 2010 rafl [...] debian.org - Correspondence added

Subject:	Re: [rt.cpan.org #47495] [PATCH] Test::More should be included as a test_requires
Date:	Fri, 7 May 2010 19:33:58 +0200
To:	Sawyer X via RT <bug-namespace-autoclean [...] rt.cpan.org>
From:	Florian Ragwitz <rafl [...] debian.org>

On Mon, May 03, 2010 at 03:04:20AM -0400, Sawyer X via RT wrote: Show quoted text

> Queue: namespace-autoclean > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=47495 > > > On Wed Jul 01 12:14:54 2009, RSRCHBOY wrote:

> > namespace::autoclean should include Test::More as a test_requires. > > > > While Test::More is indeed a core module, some distributions (e.g. Fedora) > > split core modules out into distinct sub-packages... Adding Test::More as > > a test_requires will make it easier for automated packaging / build tools > > to package (and update!) this module. > > > > Thanks! :)

> > I've included a patch for this.

Thanks, but you've patched an autogenerated file, not the dist.ini file it's generated from. Nevermind tho. I've fixed it myself for 0.11. Show quoted text

> I've also added Sub::Name because it > seems like it's requiring it in some test. You can try to eval there and > not run the test if it doesn't exist to avoid having it in Makefile.PL, > obviously.

That's a dep pulled in my CMOP anyway. -- BOFH excuse #243: The computer fleetly, mouse and all.

Download signature.asc
application/pgp-signature 189b

Message body not shown because it is not plain text.

Fri May 07 13:35:13 2010 rafl [...] debian.org - Status changed from 'open' to 'resolved'

Thu Oct 23 18:56:00 2014 ether [...] cpan.org - Fixed in 0.11 added

Bug #47495 for namespace-autoclean: Test::More should be included as a test_requires