| Subject: | Revert a section of VMS patches |
| Date: | Tue, 30 Jun 2009 14:06:15 -0400 |
| To: | bug-Module-Build [...] rt.cpan.org |
| From: | David Golden <dagolden [...] cpan.org> |
Show quoted text
---------- Forwarded message ----------
From: Craig A. Berry <craig.a.berry@gmail.com>
Date: Tue, Jun 30, 2009 at 12:42 PM
Subject: Re: [PATCH] Update Module::Build to 0.33_05
To: David Golden <dagolden@cpan.org>
Cc: perl5-porters@perl.org
On Sun, Jun 28, 2009 at 10:03 PM, David Golden<dagolden@cpan.org> wrote:
> 0.33_05 - Sun Jun 28 22:06:49 EDT 2009
> diff --git a/lib/Module/Build/Platform/VMS.pm b/lib/Module/Build/Platform/VMS.pm
> index 8175f6c..4048487 100644
> --- a/lib/Module/Build/Platform/VMS.pm
> +++ b/lib/Module/Build/Platform/VMS.pm
> @@ -2,13 +2,49 @@ package Module::Build::Platform::VMS;
This hunk needs to be reverted (well, except for the version number
editing). The identical code was already in there starting at line
467, so now we have duplicate variable and function definitions. John
and I probably sent you dueling patches or something.
> use strict;
> use vars qw($VERSION);
> -$VERSION = '0.33_02';
> +$VERSION = '0.33_05';
> $VERSION = eval $VERSION;
> use Module::Build::Base;
>
> use vars qw(@ISA);
> @ISA = qw(Module::Build::Base);
>
> +# Need to look up the feature settings. The preferred way is to use the
> +# VMS::Feature module, but that may not be available to dual life modules.
> +
> +my $use_feature;
> +BEGIN {
> + if (eval { local $SIG{__DIE__}; require VMS::Feature; }) {
> + $use_feature = 1;
> + }
> +}
> +
> +# Need to look up the UNIX report mode. This may become a dynamic mode
> +# in the future.
> +sub _unix_rpt {
> + my $unix_rpt;
> + if ($use_feature) {
> + $unix_rpt = VMS::Feature::current("filename_unix_report");
> + } else {
> + my $env_unix_rpt = $ENV{'DECC$FILENAME_UNIX_REPORT'} || '';
> + $unix_rpt = $env_unix_rpt =~ /^[ET1]/i;
> + }
> + return $unix_rpt;
> +}
> +
> +# Need to look up the EFS character set mode. This may become a dynamic
> +# mode in the future.
> +sub _efs {
> + my $efs;
> + if ($use_feature) {
> + $efs = VMS::Feature::current("efs_charset");
> + } else {
> + my $env_efs = $ENV{'DECC$EFS_CHARSET'} || '';
> + $efs = $env_efs =~ /^[ET1]/i;
> + }
> + return $efs;
> +}
> +
>
>
> =head1 NAME