Skip Menu |

This queue is for tickets about the Net-OAuth CPAN distribution.

Report information
The Basics
Id: 47453
Status: open
Priority: 0/
Queue: Net-OAuth
People
Owner: Nobody in particular
Requestors: CATONE [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Tue Jun 30 05:19:44 2009 CATONE [...] cpan.org - Ticket created
Subject: Probably incorrect 'check'
IMHO, message->check should be called during verify/sign step, not during constructor. Currently it is impossible to create object and fill required field after that. Real example: when forming request object on provider side, we first need to parse request - to get consumer key, then get consumer secret from our storage, and only then we could create request object, which will parse request again. Currently, I workarounded it with dummy consumer secret - but it's ugly. Do you agree?
  Tue Jun 30 11:11:43 2009 kgrennan [...] cpan.org - Correspondence added
Yes, I agree that having that check during the constructor phase doesn't make sense for a provider. I'll figure out a solution and update Net::OAuth in the next day or two. Thanks for the feedback! k. On Tue Jun 30 05:19:44 2009, CATONE wrote: Show quoted text
> IMHO, message->check should be called during verify/sign step, not > during constructor. Currently it is impossible to create object and fill > required field after that. > Real example: > when forming request object on provider side, we first need to parse > request - to get consumer key, then get consumer secret from our > storage, and only then we could create request object, which will parse > request again. > Currently, I workarounded it with dummy consumer secret - but it's ugly. > > Do you agree?
  Tue Jun 30 11:11:44 2009 The RT System itself - Status changed from 'new' to 'open'
  Tue Jun 30 17:30:10 2009 CATONE [...] cpan.org - Correspondence added
Thank you very much.
  Sun Mar 10 17:30:13 2013 MATHIAS [...] cpan.org - Correspondence added
Hi, I encounter the same problem with the need to use dummy value while constructing the object. It would be maybe cleaner to have the check performed only on the sign/verify call if any. This is not a blocking issue but it would still be a little simpler and more efficient to use with such a modification. Thanks, Mathias