Skip Menu |

This queue is for tickets about the Catalyst-Plugin-PageCache CPAN distribution.

Report information
The Basics
Id: 47373
Status: resolved
Priority: 0/
Queue: Catalyst-Plugin-PageCache

People
Owner: Nobody in particular
Requestors: KENTNL [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 0.22
Fixed in: (no value)



Subject: Tests Should use C::P::Cache + Cache::FileCache instead
Since 0.7 Catalyst::Plugin::Cache::FileCache sports a deprecated notice and recommends the use of Cache::FileCache with Catalyst::Plugin::Cache instead. Installation of Catalyst::Plugin::PageCache thus spews this out when C::P::C::FC is not installed: t/04cache.t ............. skipped: needs Catalyst::Plugin::Cache::FileCache for testing t/04critic.t ............ skipped: Critic test only for developers. t/05expires.t ........... skipped: needs Catalyst::Plugin::Cache::FileCache for testing t/06auto_cache.t ........ skipped: needs Catalyst::Plugin::Cache::FileCache for testing t/07set_http_headers.t .. skipped: needs Catalyst::Plugin::Cache::FileCache for testing t/08params.t ............ skipped: needs Catalyst::Plugin::Cache::FileCache for testing t/09datetime.t .......... skipped: needs Catalyst::Plugin::Cache::FileCache for testing t/10options.t ........... skipped: needs Catalyst::Plugin::Cache::FileCache for testing t/11nocache.t ........... skipped: needs Catalyst::Plugin::Cache::FileCache for testing t/12i18n.t .............. skipped: Needs Catalyst::Plugin::Cache::FileCache for testing. t/13cachehook.t ......... skipped: needs Catalyst::Plugin::Cache::FileCache for testing t/14keymaker.t .......... skipped: needs Catalyst::Plugin::Cache::FileCache for testing t/15busy_lock.t ......... skipped: needs Catalyst::Plugin::Cache::FileCache for testing This behaviour implicitly recommends that users install the said module, and also, the tests serve as example code that users will ultimately attempt to cargo cult. For the sake of propagation of quality code, Cat::Plug::PageCache's tests should also adopt the updated style.
Done. Thanks.