Bug #47349 for Net-OpenID-Consumer: Incorrect usage of last-modifed in URI::Fetch

Thu Jun 25 15:31:54 2009 cnandor [...] cpan.org - Ticket created

In Net::OpenID::URIFetch is this code: if (my $ts = ($ref->{Headers}->{'last-modified'})) { $req->if_modified_since($ts); } If I am not mistaken, last-modified is a string, and if_modified_since expects numeric. I believe instead of asking for the Last-Modified header, youw ant to call $res->last_modified directly, which gives you the value. Or HTTP::Date::str2time($ts). Which is how I am patching my local copies, so I don't continue to get errors like: Argument "Thu, 18 Jun 2009 16:55:05 GMT" isn't numeric in gmtime at /usr/local/lib/perl5/site_perl/5.10.0/HTTP/Date.pm line 36. Cheers! -- Chris Nandor pudge@pobox.com http://pudge.net/ Slashdot / SourceForge pudge@slashdot.org http://slashdot.org/

Thu Jun 25 16:34:15 2009 MART [...] cpan.org - Subject changed from (no value) to 'Incorrect usage of last-modifed in URI::Fetch'

Thu Jun 25 16:37:00 2009 MART [...] cpan.org - Correspondence added

Looks like this bug was introduced in the modifications after we forked URI::Fetch.

Thu Jun 25 16:37:01 2009 The RT System itself - Status changed from 'new' to 'open'

Fri Nov 04 20:06:25 2011 crew [...] cs.stanford.edu - Reference by ticket #72188 added

Fri Nov 04 20:18:46 2011 crew [...] cs.stanford.edu - Reference by ticket #72188 deleted

Fri Nov 04 20:18:46 2011 crew [...] cs.stanford.edu - Dependency on ticket #72188 added

Sun Nov 06 14:13:45 2011 crew [...] cs.stanford.edu - Fixed in 1.11 added

Mon Nov 07 19:16:43 2011 crew [...] cs.stanford.edu - Fixed in 1.12 added

Mon Nov 07 19:16:43 2011 crew [...] cs.stanford.edu - Fixed in 1.11 deleted

Sat Nov 12 20:34:42 2011 crew [...] cs.stanford.edu - Correspondence added

I believe this is fixed in Net-OpenID-Consumer 1.12 If you wish to try it out please make sure you've also installed the latest version of Net-OpenID-Common. Feel free to re-open (or start a new ticket) if it turns out I'm mistaken about this. Thanks for the report and sorry this took so long to get to... -- Roger Crew (new co-maintainer as of a few weeks ago)

Sat Nov 12 20:34:43 2011 crew [...] cs.stanford.edu - Status changed from 'open' to 'resolved'