Bug #47219 for RPC-XML: Broken detection whether we have Compress::Zlib

Sun Jun 21 16:39:50 2009 kmx [...] volny.cz - Ticket created

Subject:	Broken detection whether we have Compress::Zlib
Date:	Sun, 21 Jun 2009 22:39:18 +0200
To:	bug-RPC-XML [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

Hi, I have found out (in RPC-XML-0.65) that client.t fails when I have not installed Compress::Zlib The following patch to RPC/XML/Client.pm solves this issue: # Check for compression support $self->{__compress} = ''; - eval 'require "Compress::Zlib"'; + eval "require Compress::Zlib"; $self->{__compress} = $@ ? '' : 'deflate'; -- kmx

Mon Jun 22 02:11:30 2009 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #47219] AutoReply: Broken detection whether we have Compress::Zlib
Date:	Mon, 22 Jun 2009 08:10:56 +0200
To:	bug-RPC-XML [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

... and probably the similar issue in RPC/XML/Server.pm unless ($args{no_compress}) { + eval 'require "Compress::Zlib"'; - eval "require Compress::Zlib"; eval "require Compress::Zlib"; $self->{__compress} = $@ ? '' : 'deflate'; Generaly you have to use: require "Modulename::In::Quotation::Marks" if you want to catch unavailable module. See http://www.perl.com/doc/manual/html/pod/perlfunc/require.html -- kmx

Thu Jul 09 07:57:11 2009 rjray [...] blackperl.com - Status changed from 'new' to 'open'

Thu Jul 09 07:57:15 2009 rjray [...] blackperl.com - Taken

Thu Jul 09 07:58:43 2009 rjray [...] blackperl.com - Correspondence added

Oddly, both files already had that change to the eval lines. Are you sure you were looking at the most-current versions? Either way, I re-did those tests so that they're done once, in a BEGIN block, and not repeated every time new() is called. The "require" would be (mostly) a no-op, but the trinary test doesn't need to execute every time... -- """"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" Randy J. Ray Silicon Valley Scale Modelers: http://www.svsm.org rjray@blackperl.com randy.j.ray@gmail.com

Thu Jul 09 15:03:43 2009 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #47219] Broken detection whether we have Compress::Zlib
Date:	Thu, 09 Jul 2009 21:03:19 +0200
To:	bug-RPC-XML [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

Hi, I have taken the latest version from your Git repository In order to make all tests pass on Win32 without Compress::Zlib I have to patch *./lib/RPC/XML/Server.pm *and *./lib/RPC/XML/Client.pm* by changing the original line (in both files in BEGIN block): *eval "require Compress::Zlib";* into this form: *eval 'require "Compress::Zlib"'; * According to http://www.perl.com/doc/manual/html/pod/perlfunc/require.html the required module name should be in quotation marks if we want to catch the complain about not finding the module. With the above described patch all tests pass on Win32/strawberry/5.8.9. I have also tried Win32/strawberry/5.10.0 but I have a problem with installing Scalar::Util upgrade to 1.2, without this RPC::XML tests hang up. I will try to investigate further details. -- kmx

Fri Jul 10 02:47:20 2009 rjray [...] blackperl.com - Correspondence added

D'oh! I mid-read the patch, and since it was just one line I thought to "apply" it by hand. But since I mid-read it, I got it wrong. Looks like 0.67 will be coming out sooner than I thought! -- """"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" Randy J. Ray Silicon Valley Scale Modelers: http://www.svsm.org rjray@blackperl.com randy.j.ray@gmail.com

Fri Jul 10 04:36:38 2009 rjray [...] blackperl.com - Correspondence added

OK, 0.67 should get it right, now. I've added a new test suite to specifically test the detection of Compress::Zlib, including faking it's absence so that I test both detection AND non-detection :-). -- """"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" Randy J. Ray Silicon Valley Scale Modelers: http://www.svsm.org rjray@blackperl.com randy.j.ray@gmail.com

Tue Aug 04 13:23:03 2009 rjray [...] blackperl.com - Fixed in 0.67 added

Tue Aug 04 13:23:03 2009 rjray [...] blackperl.com - Correspondence added

-- """"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" Randy J. Ray Silicon Valley Scale Modelers: http://www.svsm.org rjray@blackperl.com randy.j.ray@gmail.com

Tue Aug 04 13:23:04 2009 rjray [...] blackperl.com - Status changed from 'open' to 'resolved'