Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 46971
Status: open
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: user42 [...] zip.com.au
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Mon Jun 15 17:53:03 2009 user42 [...] zip.com.au - Ticket created
Subject: ProhibitLocalVars on localized hash entry
Date: Tue, 16 Jun 2009 07:52:34 +1000
To: bug-Perl-Critic [...] rt.cpan.org
From: Kevin Ryde <user42 [...] zip.com.au>
I've had some success using "local" to make block-scoped hash value settings, like flags on an object for recursion protection etc, { local $self->{'update_in_progress'} = 1; ... } It'd be good if ProhibitLocalVars allowed expressions like that (array element, hash element, other sorts of dereference), on the basis the aim of the policy is to pick up places which ought to be "my" instead of "local". (Or alternatively, if the above is a bad idea then further notes in the docs about why the policy is flagging it ...)
Index: ProhibitLocalVars.run =================================================================== --- ProhibitLocalVars.run (revision 3341) +++ ProhibitLocalVars.run (working copy) @@ -27,6 +27,8 @@ local $SIG{HUP} \&handler; local $INC{$module} = $path; +local $self->{'update_in_progress'} = $path; + #----------------------------------------------------------------------------- ##############################################################################
  Mon Jun 22 15:32:37 2009 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #46971] ProhibitLocalVars on localized hash entry
Date: Mon, 22 Jun 2009 15:32:09 -0400
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Kevin Ryde via RT wrote: Show quoted text
> I've had some success using "local" to make block-scoped hash value > settings, like flags on an object for recursion protection etc,
Interesting. I never thought about applying "local" to a lexical hash reference. I've localized individual values in a global hash before, of course, but never in a lexical one. I'm thinking that the current behavior should still be the default, simply to discourage use of local by those who don't know what's going on, but assuming that you do know what it's doing, I see no reason to complain about it. So, I think we should have an option for this to turn this situation off.
  Mon Jun 22 15:32:37 2009 The RT System itself - Status changed from 'new' to 'open'
  Wed Jun 24 19:39:22 2009 user42 [...] zip.com.au - Correspondence added
Subject: Re: [rt.cpan.org #46971] ProhibitLocalVars on localized hash entry
Date: Thu, 25 Jun 2009 09:38:04 +1000
To: bug-Perl-Critic [...] rt.cpan.org
From: Kevin Ryde <user42 [...] zip.com.au>
"Elliot Shank via RT" <bug-Perl-Critic@rt.cpan.org> writes: Show quoted text
> > I think we should have an option for this to turn this situation off.
I shouldn't think anyone could write "local $foo->{...}" without meaning it, it couldn't be a mistaken "my"; so I wouldn't worry about an option. Perhaps keep it nice and narrow though, just a hash or array dereference ie. local $foo->..., initially if you like, and see how that goes.
  Thu Jun 25 07:44:46 2009 perl [...] galumph.com - Correspondence added
Subject: Re: [rt.cpan.org #46971] ProhibitLocalVars on localized hash entry
Date: Thu, 25 Jun 2009 07:44:13 -0400
To: bug-Perl-Critic [...] rt.cpan.org
From: Elliot Shank <perl [...] galumph.com>
Kevin Ryde via RT wrote: Show quoted text
> "Elliot Shank via RT" <bug-Perl-Critic@rt.cpan.org> writes:
>> I think we should have an option for this to turn this situation off.
> > I shouldn't think anyone could write "local $foo->{...}" without meaning > it, it couldn't be a mistaken "my"; so I wouldn't worry about an option.
You don't? What fantasy island do you live on? I guarantee you that beginners get mixed up between my and local all the time.