Skip Menu |

This queue is for tickets about the ExtUtils-MakeMaker CPAN distribution.

Report information
The Basics
Id: 4687
Status: resolved
Priority: 0/
Queue: ExtUtils-MakeMaker

People
Owner: Nobody in particular
Requestors: PPrymmer [...] factset.com
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: (no value)
Fixed in: (no value)



Subject: Fix ExtUtils::Command so it fully deletes files on VMS
Ensure ExtUtils::Command's rm functions fully delete VMS versioned files so things like the clean target really delete the files.
From: Craig Berry
[guest - Mon Dec 15 19:25:57 2003]: The attached patch will take care of this.
--- lib/ExtUtils/Command.pm;-0 Sat Nov 29 08:28:08 2003 +++ lib/ExtUtils/Command.pm Sat Dec 20 10:50:04 2003 @@ -109,9 +109,10 @@ foreach (@ARGV) { next unless -f $_; - next if unlink($_); chmod(0777,$_); - next if unlink($_); + my $delete_count = 0; + $delete_count++ while unlink($_); + next unless $delete_count; carp "Cannot delete $_:$!"; } }
[guest - Sat Dec 20 12:32:34 2003]: Show quoted text
> [guest - Mon Dec 15 19:25:57 2003]: > > The attached patch will take care of this.
Shouldn't that be "next if $delete_count"? It'll be in 6.22 with that fix.