Bug #46808 for DBIx-Class: DBIx::Class::Schema::ddl

Tue Jun 09 15:11:38 2009 Support [...] RoxSoft.co.uk - Ticket created

Subject:

DBIx::Class::Schema::ddl_filename method signature changed

In DBIx::Class 0.8009 the Schema::ddl_filename method had a signature of $type, $dir, $version, $pversion. In 0.8103 this has changed to $type, $version, $dir $preversion. This change is not backwardly compatible. From the schema docs "You may override this method in your schema if you wish to use a different format.", so it is a public method

Tue Jun 09 17:42:34 2009 Support [...] RoxSoft.co.uk - Correspondence added

Have attached doc patch

--- Schema.pm 2009-06-09 22:21:39.000000000 +0100 +++ Schema.pm 2009-06-09 22:35:42.000000000 +0100 @@ -1123,6 +1123,16 @@ You may override this method in your schema if you wish to use a different format. +Prior to DBIx::Class version 0.08100 this method had this signature: + + my $filename = $table->ddl_filename($type, $dir, $version, $preversion) + +Variables C<$dir> and C<$version> where reversed. To maintain backward +compatibility use the current method signature and add this line to any +override methods + + ($dir, $version) = ($version, $dir) if ($DBIx::Class::VERSION < 0.08100); + =cut sub ddl_filename {

Sat Jun 27 06:52:53 2009 ribasushi [...] leporine.io - Correspondence added

On Tue Jun 09 17:42:34 2009, PJFL wrote: Show quoted text

> Have attached doc patch

Committed with some changed at http://dev.catalyst.perl.org/svnweb/bast/revision?rev=6803

Sat Jun 27 06:52:53 2009 The RT System itself - Status changed from 'new' to 'open'

Thu Jul 09 23:28:17 2009 ribasushi [...] leporine.io - Fixed in 0.08108 added

Thu Jul 09 23:28:31 2009 ribasushi [...] leporine.io - Status changed from 'open' to 'resolved'

Bug #46808 for DBIx-Class: DBIx::Class::Schema::ddl_filename method signature changed