Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Geo-ShapeFile CPAN distribution.

Report information
The Basics
Id: 46698
Status: resolved
Priority: 0/
Queue: Geo-ShapeFile
People
Owner: SLAFFAN [...] cpan.org
Requestors: jpierce [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 2.52
Fixed in: 2.54

History Show all quoted text
  Fri Jun 05 21:46:42 2009 jpierce [...] cpan.org - Ticket created
Subject: Funkiness fetching end-points
Trying to determine whether a polyline had a positive or negative slope, I used: printf "%i : %i\n", $shape->has_point($shape->x_min(), $shape->y_min()), $shape->has_point($shape->x_min(), $shape->y_max()); Which begot: Can't call method "X" without a package or object reference at /usr/local/share/perl/5.10.0/Geo/ShapeFile.pm line 397. I ended up using ->X and ->Y on ($shape->points)[0,-1], but the former ought to have worked? In particular, the work-around assumes points are always listed in order...
  Sun Feb 09 03:31:21 2014 SLAFFAN [...] cpan.org - Correspondence added
Hello Jerrad, Is this still an issue? (I assume so). In any case, development is now at https://github.com/shawnlaffan/Geo-ShapeFile if you are able to submit a pull request, ideally with a test case. If not then I'll look into it in more detail when I get the opportunity. Regards, Shawn. On Fri Jun 05 21:46:42 2009, JPIERCE wrote: Show quoted text
> Trying to determine whether a polyline had a positive or negative slope, > I used: > > printf "%i : %i\n", $shape->has_point($shape->x_min(), > $shape->y_min()), $shape->has_point($shape->x_min(), $shape->y_max()); > > Which begot: > Can't call method "X" without a package or object reference at > /usr/local/share/perl/5.10.0/Geo/ShapeFile.pm line 397. > > I ended up using ->X and ->Y on ($shape->points)[0,-1], but the former > ought to have worked? In particular, the work-around assumes points are > always listed in order...
  Sun Feb 09 03:31:21 2014 The RT System itself - Status changed from 'new' to 'open'
  Sun Feb 09 03:31:22 2014 SLAFFAN [...] cpan.org - Taken
  Sun Feb 09 08:37:16 2014 belg4mit [...] pthbb.org - Correspondence added
Subject: Re: [rt.cpan.org #46698] Funkiness fetching end-points
Date: Sun, 09 Feb 2014 08:37:03 -0500
To: bug-Geo-ShapeFile [...] rt.cpan.org
From: Jerrad Pierce <belg4mit [...] pthbb.org>
I don't know. It's been so long, I can't even recall what Imwas working on, sorry.
  Sun Feb 09 15:26:46 2014 SLAFFAN [...] cpan.org - Correspondence added
No worries Jerrad, I can confirm it is still an issue. It appears that somewhere along the line the x-coordinate value is being passed to Geo::ShapeFile::area_contains_point, rather than a point object. I'll run all development on the github issue tracker now if you feel like followng it. Shawn. On Sun Feb 09 08:37:16 2014, belg4mit@pthbb.org wrote: Show quoted text
> I don't know. It's been so long, I can't even recall what Imwas > working on, sorry.
  Sun Feb 09 15:52:48 2014 SLAFFAN [...] cpan.org - Correspondence added
That didn't take long. The code was passing raw coordinates to has_point, whereas it expects a point object. I have updated the docs to be clearer that it needs a point object. I'll close this ticket when the next version is released. Regards, Shawn. On Sun Feb 09 15:26:46 2014, SLAFFAN wrote: Show quoted text
> No worries Jerrad, > > I can confirm it is still an issue. > > It appears that somewhere along the line the x-coordinate value is > being passed to Geo::ShapeFile::area_contains_point, rather than a > point object. > > I'll run all development on the github issue tracker now if you feel > like followng it. > > Shawn. > > > On Sun Feb 09 08:37:16 2014, belg4mit@pthbb.org wrote:
> > I don't know. It's been so long, I can't even recall what Imwas > > working on, sorry.
  Sun Feb 09 15:52:48 2014 SLAFFAN [...] cpan.org - Status changed from 'open' to 'patched'
  Tue Feb 11 17:12:18 2014 SLAFFAN [...] cpan.org - Correspondence added
Fixed in 2.54 On Sun Feb 09 15:52:48 2014, SLAFFAN wrote: Show quoted text
> That didn't take long. > > The code was passing raw coordinates to has_point, whereas it expects > a point object. > > I have updated the docs to be clearer that it needs a point object. > > I'll close this ticket when the next version is released. > > Regards, > Shawn. > > > On Sun Feb 09 15:26:46 2014, SLAFFAN wrote:
> > No worries Jerrad, > > > > I can confirm it is still an issue. > > > > It appears that somewhere along the line the x-coordinate value is > > being passed to Geo::ShapeFile::area_contains_point, rather than a > > point object. > > > > I'll run all development on the github issue tracker now if you feel > > like followng it. > > > > Shawn. > > > > > > On Sun Feb 09 08:37:16 2014, belg4mit@pthbb.org wrote:
> > > I don't know. It's been so long, I can't even recall what Imwas > > > working on, sorry.
  Tue Feb 11 17:12:20 2014 SLAFFAN [...] cpan.org - Status changed from 'patched' to 'resolved'
  Tue Feb 11 17:12:20 2014 SLAFFAN [...] cpan.org - Fixed in 2.54 added