| Subject: | Perl::Critic::Policy::CodeLayout::ProhibitHashBarewords incorrectly marked with PBP theme |
Hi Marcelo-
First, let me congratulate and thank you for Perl-Critic-Itch. I'm
always very happy to see new Policy distributions on CPAN.
I noticed that CodeLayout::ProhibitHashBarewords is marked with a 'pbp'
theme. However, this Policy doesn't really come from Perl Best
Practices. In fact, I think Conway prefers to NOT quote bareword hash keys.
The 'pbp' theme is intended for Policies that come directly from the
book. So I think you should remove the 'pbp' theme from the Policy.
You might also consider adding an 'itch' theme. Most third-party Policy
authors will add a custom theme to all their Policies, which makes it
easier for a user to switch them all on or off.
Also, when you call $self->violation() in your Policy, you can pass a
string for the explanation, instead of a reference to an array of PBP
page numbers. This let's you provide further explanation of the
violation, rather than pointing the user to PBP. All of the non-PBP
Policies in Perl-Critic use this feature.
Otherwise, this is very nice work!
-Jeff