Skip Menu |

This queue is for tickets about the Text-Diff-Parser CPAN distribution.

Report information
The Basics
Id: 46426
Status: resolved
Priority: 0/
Queue: Text-Diff-Parser

People
Owner: Nobody in particular
Requestors: JHANNAH [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.0900
Fixed in: (no value)



Subject: Unified diff parsing fails on any removal of a line that starts with '--'
Below, an example of the parsing failure. Thanks! j $ cat mysql.pl use Text::Diff::Parser; $parser = Text::Diff::Parser->new( File=>'mysql.diff' ); $ cat mysql.diff Index: oxi_room_counts.sql =================================================================== --- oxi_room_counts.sql (revision 5904) +++ oxi_room_counts.sql (working copy) @@ -2,7 +2,7 @@ -- -- Host: localhost Database: omnihub -- ------------------------------------------------------ --- Server version 5.1.23-rc +-- Server version 5.1.23-rc-log /*!40101 SET @OLD_CHARACTER_SET_CLIENT=@@CHARACTER_SET_CLIENT */; /*!40101 SET @OLD_CHARACTER_SET_RESULTS=@@CHARACTER_SET_RESULTS */; $ perl mysql.pl Missing +++ line before +-- Server version 5.1.23-rc-log
Fixed. I've included your diff as a unit test. 0.1000 has been uploaded to PAUSE. Thank you for the bug report.
Turns out "patched" still means "open"