Bug #46405 for IO: [PATCH] return value on non blocking connect

Wed May 27 05:31:54 2009 KNI [...] cpan.org - Ticket created

Subject:

[PATCH] return value on non blocking connect

The attached patch make IO::Socket::connect behavior similar to CORE::connect with $sock->blocking(0);

Subject:

IO_Socket.patch

--- lib/IO/Socket.pm Wed May 27 12:20:07 2009 +++ lib/IO/Socket.pm_new Wed May 27 12:20:01 2009 @@ -142,7 +142,11 @@ $! = $err if $err; - $err ? undef : $sock; + if (!$blocking and $!{EINPROGRESS} or $!{EWOULDBLOCK}) { + undef; + } else { + $err ? undef : $sock; + } } # Enable/disable blocking IO on sockets.

Wed May 27 08:18:41 2009 gbarr [...] pobox.com - Correspondence added

Subject:	Re: [rt.cpan.org #46405] [PATCH] return value on non blocking connect
Date:	Wed, 27 May 2009 07:18:13 -0500
To:	bug-IO [...] rt.cpan.org
From:	Graham Barr <gbarr [...] pobox.com>

connect was specifically written to still return $sock when using non blocking, that is the purpose of elsif ($blocking || !($!{EINPROGRESS} || $!{EWOULDBLOCK})) { $err = $!; $@ = "connect: $!"; } your patch would be the same as changing that code to be else { $err = $!; $@ = "connect: $!"; } The point of returning $sock when a non blocking connection is pending is so that code can use simple trust of the return to determine if there is an error that needs handling. When doing non-blocking connect EINPROGRESS and EWOULDBLOCK are not errors, but expects. The callers code would then go on to detecting when the connect is complete using select Graham.

Wed May 27 08:18:42 2009 The RT System itself - Status changed from 'new' to 'open'

Wed May 27 08:18:49 2009 GBARR [...] CPAN.ORG - Status changed from 'open' to 'rejected'

Wed May 27 09:20:15 2009 KNI [...] cpan.org - Correspondence added

It is even better than CORE::connect! Thanks

Wed May 27 09:20:16 2009 The RT System itself - Status changed from 'rejected' to 'open'

Wed May 27 09:23:02 2009 KNI [...] cpan.org - Status changed from 'open' to 'rejected'