Bug #46380 for DBD-SQLite: enable FTS3 extended query syntax

Tue May 26 15:23:39 2009 redneb [...] gmx.com - Ticket created

Subject:	enable FTS3 extended query syntax
Date:	Tue, 26 May 2009 15:23:03 -0400
To:	bug-DBD-SQLite [...] rt.cpan.org
From:	redneb [...] gmx.com

Since FTS3 is now enabled by default it would be nice if the extended query syntax was also enabled. This can be done by defining the SQLITE_ENABLE_FTS3_PARENTHESIS compile time option of sqlite. The extended syntax allows FTS3 queries to use operators AND and NOT as well as nested parentheses.

Tue May 26 22:13:06 2009 adamkennedybackup [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #46380] enable FTS3 extended query syntax
Date:	Wed, 27 May 2009 12:12:44 +1000
To:	bug-DBD-SQLite [...] rt.cpan.org
From:	Adam Kennedy <adamkennedybackup [...] gmail.com>

Thanks for the report. We can easily enable this compile option, but as things stand we don't have any tests to validate the addition. Since you understand the feature you're after, if you'd like to expedite the feature addition by producing some test scripts for the feature so that we can validate it, I can give you commit rights to add them. Adam K 2009/5/27 redneb via RT <bug-DBD-SQLite@rt.cpan.org>: Show quoted text

> Tue May 26 15:23:39 2009: Request 46380 was acted upon. > Transaction: Ticket created by redneb@gmx.com > Queue: DBD-SQLite > Subject: enable FTS3 extended query syntax > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: redneb@gmx.com > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=46380 > > > > Since FTS3 is now enabled by default it would be nice if the extended > query syntax was also enabled. This can be done by defining the > SQLITE_ENABLE_FTS3_PARENTHESIS compile time option of sqlite. The > extended syntax allows FTS3 queries to use operators AND and NOT as well > as nested parentheses. > >

Tue May 26 22:13:07 2009 The RT System itself - Status changed from 'new' to 'open'

Wed May 27 02:37:55 2009 redneb [...] gmx.com - Correspondence added

Subject:	Re: [rt.cpan.org #46380] enable FTS3 extended query syntax
Date:	Wed, 27 May 2009 02:37:32 -0400
To:	Adam Kennedy via RT <bug-DBD-SQLite [...] rt.cpan.org>
From:	redneb [...] gmx.com

I just found out that SQLITE_ENABLE_FTS3_PARENTHESIS enables a new syntax that breaks compatibility with the legacy one. According to the fts3_expr.c file from the sqlite sources, the differences between the new and the legacy syntaxes are a) The new syntax supports parenthesis. The old does not. b) The new syntax supports the AND and NOT operators. The old does not. c) The old syntax supports the "-" token qualifier. This is not supported by the new syntax (it is replaced by the NOT operator). d) When using the old syntax, the OR operator has a greater precedence than an implicit AND. When using the new, both implicit and explicit AND operators have a higher precedence than OR. Therefore, enabling the new syntax is probably not a good idea. On Tue, May 26, 2009 at 10:13:08PM -0400, Adam Kennedy via RT wrote: Show quoted text

><URL: http://rt.cpan.org/Ticket/Display.html?id=46380 > > >Thanks for the report. > >We can easily enable this compile option, but as things stand we don't >have any tests to validate the addition. > >Since you understand the feature you're after, if you'd like to >expedite the feature addition by producing some test scripts for the >feature so that we can validate it, I can give you commit rights to >add them. > >Adam K

Wed May 27 03:05:40 2009 adamkennedybackup [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #46380] enable FTS3 extended query syntax
Date:	Wed, 27 May 2009 17:05:21 +1000
To:	bug-DBD-SQLite [...] rt.cpan.org
From:	Adam Kennedy <adamkennedybackup [...] gmail.com>

(And that's why we wait till there's tests before adding new features) :) 2009/5/27 redneb via RT <bug-DBD-SQLite@rt.cpan.org>: Show quoted text

> Queue: DBD-SQLite > Ticket <URL: http://rt.cpan.org/Ticket/Display.html?id=46380 > > > I just found out that SQLITE_ENABLE_FTS3_PARENTHESIS enables a new > syntax that breaks compatibility with the legacy one. According to the > fts3_expr.c file from the sqlite sources, the differences between the > new and the legacy syntaxes are > > a) The new syntax supports parenthesis. The old does not. > b) The new syntax supports the AND and NOT operators. > The old does not. > c) The old syntax supports the "-" token qualifier. > This is not supported by the new syntax (it is > replaced by the NOT operator). > d) When using the old syntax, the OR operator has > a greater precedence than an implicit AND. When > using the new, both implicit and explicit AND > operators have a higher precedence than OR. > > Therefore, enabling the new syntax is probably not a good idea. > > > > On Tue, May 26, 2009 at 10:13:08PM -0400, Adam Kennedy via RT wrote:

>><URL: http://rt.cpan.org/Ticket/Display.html?id=46380 > >> >>Thanks for the report. >> >>We can easily enable this compile option, but as things stand we don't >>have any tests to validate the addition. >> >>Since you understand the feature you're after, if you'd like to >>expedite the feature addition by producing some test scripts for the >>feature so that we can validate it, I can give you commit rights to >>add them. >> >>Adam K

> >

Tue Aug 31 22:14:05 2010 ishigaki [...] cpan.org - Correspondence added

Hi. For your information, SQLITE_ENABLE_FTS3_PARENTHESIS has been enabled by default since DBD::SQLite 1.30_04 with custom tokenizer support (by Laurent Dami). Please check the latest dev version when you have some spare time to see if it works for you. Thanks. Kenichi On 2009-5-27 Wed 02:37:55, redneb@gmx.com wrote: Show quoted text

> I just found out that SQLITE_ENABLE_FTS3_PARENTHESIS enables a new > syntax that breaks compatibility with the legacy one. According to

the Show quoted text

> fts3_expr.c file from the sqlite sources, the differences between the > new and the legacy syntaxes are > > a) The new syntax supports parenthesis. The old does not. > b) The new syntax supports the AND and NOT operators. > The old does not. > c) The old syntax supports the "-" token qualifier. > This is not supported by the new syntax (it is > replaced by the NOT operator). > d) When using the old syntax, the OR operator has > a greater precedence than an implicit AND. When > using the new, both implicit and explicit AND > operators have a higher precedence than OR. > > Therefore, enabling the new syntax is probably not a good idea. > > > > On Tue, May 26, 2009 at 10:13:08PM -0400, Adam Kennedy via RT wrote:

> ><URL: http://rt.cpan.org/Ticket/Display.html?id=46380 > > > > >Thanks for the report. > > > >We can easily enable this compile option, but as things stand we

don't Show quoted text

> >have any tests to validate the addition. > > > >Since you understand the feature you're after, if you'd like to > >expedite the feature addition by producing some test scripts for the > >feature so that we can validate it, I can give you commit rights to > >add them. > > > >Adam K

Tue Aug 31 22:14:08 2010 ishigaki [...] cpan.org - Status changed from 'open' to 'resolved'