Subject: | t/GtkStyle.t Fails with Gtk < 2.16 |
Dear Torsten Schönfeld,
Hi. This is imacat from Taiwan. I found that t/GtkStyle.t fails
when running “make test” on my Debian 5.0.1 Lenny. It expects 126 tests
while only 125 tests are run. I tried to investigate further. It seems
that with Gtk < 2.16, the last SKIP block instructs to skips 13 tests
when there are only 12.
The terminal log is attached below. I have made a simple patch that
should work, in the hope that it helps. Please tell me if you need any
information, or if I could be of any help. Thank you.
imacat@leaf perl/Gtk2-1.220 % make test
t/00.Gtk2.t ........................ 1/44 # Testing Gtk2 1.220
# Running against gtk+ 2.12.12
# Compiled against gtk+ 2.12.12
# and pango 1.20.5
t/00.Gtk2.t ........................ ok
...
t/GtkStyle.t ....................... 1/125 # Looks like you planned 125
tests but ran 126.
t/GtkStyle.t ....................... Dubious, test returned 255 (wstat
65280, 0xff00)
All 125 subtests passed
(less 13 skipped subtests: 112 okay)
...
t/version-checks.t ................. ok
Test Summary Report
-------------------
t/GtkStyle.t (Wstat: 65280 Tests: 126 Failed: 1)
Failed test: 126
Non-zero exit status: 255
Parse errors: Bad plan. You planned 125 tests but ran 126.
Files=217, Tests=4710, 252 wallclock secs (12.66 usr 2.54 sys + 156.38
cusr 45.90 csys = 217.48 CPU)
Result: FAIL
Failed 1/217 test programs. 1/4710 subtests failed.
make: *** [test_dynamic] Error 255
imacat@leaf perl/Gtk2-1.220 % perl -Iblib/lib -Iblib/arch t/GtkStyle.t
1..125
ok 1 - The object isa Gtk2::Style
...
ok 113
ok 114 # skip get is new in 2.16
ok 115 # skip get is new in 2.16
ok 116 # skip get is new in 2.16
ok 117 # skip get is new in 2.16
ok 118 # skip get is new in 2.16
ok 119 # skip get is new in 2.16
ok 120 # skip get is new in 2.16
ok 121 # skip get is new in 2.16
ok 122 # skip get is new in 2.16
ok 123 # skip get is new in 2.16
ok 124 # skip get is new in 2.16
ok 125 # skip get is new in 2.16
ok 126 # skip get is new in 2.16
# Looks like you planned 125 tests but ran 126.
imacat@leaf perl/Gtk2-1.220 %
Subject: | Gtk2-1.220-gtkstyle-skip12.diff |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
diff -u -r Gtk2-1.220.orig/t/GtkStyle.t Gtk2-1.220/t/GtkStyle.t
- --- Gtk2-1.220.orig/t/GtkStyle.t 2009-03-18 02:42:56.000000000 +0800
+++ Gtk2-1.220/t/GtkStyle.t 2009-05-24 20:19:04.000000000 +0800
@@ -135,7 +135,7 @@
}
SKIP: {
- - skip("get is new in 2.16", 13)
+ skip("get is new in 2.16", 12)
unless (Gtk2->CHECK_VERSION(2, 16, 0));
# Test different properties (gint, gboolean, gchar* and GObject)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkoZO1EACgkQi9gubzC5S1z5YACghPJtw5C0AOpwCnkKsyNXW8yd
wPoAoJay7i+NWc20+c5+jfjndrwkvyyM
=zQK9
-----END PGP SIGNATURE-----